Commit 08289e8
committed
fix: validate T-vs-space in incompatible path instead of CORRECTED_COMPATIBLE_FORMATS
Adding the format to CORRECTED_COMPATIBLE_FORMATS made it always go to
GPU, but cuDF's %3f requires exactly 3 fractional digits while CPU
accepts 1-3. This caused ParseDateTimeSuite to fail for inputs like
"1999-12-31 11:59:59.9".
Instead, keep the format on the incompatible path (so it falls back to
CPU without incompatDateFormats) and add targeted validation there:
- Reject inputs with T where the format expects space (fixes #13759)
- Use cuDF isTimestamp to reject truly unparseable strings
Signed-off-by: Allen Xu <allxu@nvidia.com>
Made-with: Cursor1 parent 2afff86 commit 08289e8
1 file changed
Lines changed: 20 additions & 6 deletions
Lines changed: 20 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
607 | 607 | | |
608 | 608 | | |
609 | 609 | | |
610 | | - | |
611 | | - | |
612 | 610 | | |
613 | 611 | | |
614 | 612 | | |
| |||
708 | 706 | | |
709 | 707 | | |
710 | 708 | | |
711 | | - | |
712 | | - | |
713 | | - | |
714 | | - | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
715 | 729 | | |
716 | 730 | | |
717 | 731 | | |
| |||
0 commit comments