Skip to content

Commit 0dbfbb9

Browse files
Merge pull request #255 from NVIDIA/add-commit-label-to-image
USE GIT_COMMIT in container builds
2 parents f9ebb0e + 2a23cc4 commit 0dbfbb9

19 files changed

Lines changed: 92 additions & 0 deletions

File tree

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ $(DRIVER_BUILD_TARGETS):
162162
--build-arg DRIVER_BRANCH="$(DRIVER_BRANCH)" \
163163
--build-arg CUDA_VERSION="$(CUDA_VERSION)" \
164164
--build-arg CVE_UPDATES="$(CVE_UPDATES)" \
165+
--build-arg GIT_COMMIT="$(GIT_COMMIT)" \
165166
$(DOCKER_BUILD_ARGS) \
166167
--file $(DOCKERFILE) \
167168
$(CURDIR)/$(SUBDIR)

rhel10/Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ ARG DRIVER_VERSION
4343
ENV DRIVER_VERSION=$DRIVER_VERSION
4444
ARG DRIVER_BRANCH
4545
ENV DRIVER_BRANCH=$DRIVER_BRANCH
46+
ARG GIT_COMMIT
4647

4748
# Arg to indicate if driver type is either of passthrough/baremetal or vgpu
4849
ARG DRIVER_TYPE=passthrough
@@ -99,6 +100,7 @@ LABEL io.k8s.display-name="NVIDIA Driver Container"
99100
LABEL name="NVIDIA Driver Container"
100101
LABEL vendor="NVIDIA"
101102
LABEL version="${DRIVER_VERSION}"
103+
LABEL vcs-ref="${GIT_COMMIT}"
102104
LABEL release="N/A"
103105
LABEL summary="Provision the NVIDIA driver through containers"
104106
LABEL description="See summary"

rhel10/precompiled/Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,8 @@ ARG BUILD_ARCH
9393
ARG TARGET_ARCH
9494
ENV TARGETARCH=${TARGET_ARCH}
9595

96+
ARG GIT_COMMIT
97+
9698
# Force using provided RHSM registration
9799
ENV SMDEV_CONTAINER_OFF=1
98100

@@ -179,6 +181,7 @@ LABEL io.k8s.display-name="NVIDIA Driver Container"
179181
LABEL name="NVIDIA Driver Container"
180182
LABEL vendor="NVIDIA"
181183
LABEL version="${DRIVER_VERSION}"
184+
LABEL vcs-ref="${GIT_COMMIT}"
182185
LABEL release="${KERNEL_VERSION}-${OS_TAG}"
183186
LABEL summary="Provision the NVIDIA driver through containers"
184187
LABEL description="See summary"

rhel10/precompiled/Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
GIT_COMMIT ?= $(shell git describe --match="" --dirty --long --always --abbrev=40 2> /dev/null || echo "")
2+
13
RHEL_VERSION ?= 10.0
24
RHEL_VERSION_MAJOR = $(shell echo "${RHEL_VERSION}" | awk -F. '{print $$1}')
35

@@ -70,6 +72,7 @@ image: rhsm-register
7072
--build-arg DRIVER_STREAM_TYPE=${DRIVER_STREAM_TYPE} \
7173
--build-arg BASE_URL=${BASE_URL} \
7274
--build-arg OS_TAG=${OS_TAG} \
75+
--build-arg GIT_COMMIT=${GIT_COMMIT} \
7376
--tag ${IMAGE_REGISTRY}/${IMAGE_NAME}:${DRIVER_VERSION}-${KERNEL_VERSION_TAG}-${OS_TAG} \
7477
--progress=plain \
7578
--file ${DOCKERFILE} .

rhel8/Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ ARG DRIVER_VERSION
4242
ENV DRIVER_VERSION=$DRIVER_VERSION
4343
ARG DRIVER_BRANCH
4444
ENV DRIVER_BRANCH=$DRIVER_BRANCH
45+
ARG GIT_COMMIT
4546

4647
# Arg to indicate if driver type is either of passthrough/baremetal or vgpu
4748
ARG DRIVER_TYPE=passthrough
@@ -97,6 +98,7 @@ LABEL io.k8s.display-name="NVIDIA Driver Container"
9798
LABEL name="NVIDIA Driver Container"
9899
LABEL vendor="NVIDIA"
99100
LABEL version="${DRIVER_VERSION}"
101+
LABEL vcs-ref="${GIT_COMMIT}"
100102
LABEL release="N/A"
101103
LABEL summary="Provision the NVIDIA driver through containers"
102104
LABEL description="See summary"

rhel8/precompiled/Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ ENV DRIVER_VERSION=${DRIVER_VERSION}
6767
ARG TARGET_ARCH=''
6868
ENV TARGETARCH=${TARGET_ARCH}
6969

70+
ARG GIT_COMMIT
71+
7072
# Force using provided RHSM registration
7173
ENV SMDEV_CONTAINER_OFF=1
7274

@@ -146,6 +148,7 @@ LABEL io.k8s.display-name="NVIDIA Driver Container"
146148
LABEL name="NVIDIA Driver Container"
147149
LABEL vendor="NVIDIA"
148150
LABEL version="${DRIVER_VERSION}"
151+
LABEL vcs-ref="${GIT_COMMIT}"
149152
LABEL release="N/A"
150153
LABEL summary="Provision the NVIDIA driver through containers"
151154
LABEL description="See summary"

rhel8/precompiled/Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
DOCKERFILE = Dockerfile
2+
GIT_COMMIT ?= $(shell git describe --match="" --dirty --long --always --abbrev=40 2> /dev/null || echo "")
23
RHEL_VERSION ?= 8.6
34
CUDA_VERSION ?= 12.6.0
45
CUDA_DIST ?= ubi8
@@ -52,6 +53,7 @@ image: rhsm-register
5253
--build-arg DRIVER_TOOLKIT_IMAGE=${DRIVER_TOOLKIT_IMAGE} \
5354
--build-arg DRIVER_TYPE=${DRIVER_TYPE} \
5455
--build-arg BASE_URL=${BASE_URL} \
56+
--build-arg GIT_COMMIT=${GIT_COMMIT} \
5557
--tag ${IMAGE_REGISTRY}/${IMAGE_NAME}:${DRIVER_VERSION}-${KERNEL_VERSION}-${OS_TAG} \
5658
--progress=plain \
5759
--file ${DOCKERFILE} .

rhel9/Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ ARG DRIVER_VERSION
4242
ENV DRIVER_VERSION=$DRIVER_VERSION
4343
ARG DRIVER_BRANCH
4444
ENV DRIVER_BRANCH=$DRIVER_BRANCH
45+
ARG GIT_COMMIT
4546

4647
# Arg to indicate if driver type is either of passthrough/baremetal or vgpu
4748
ARG DRIVER_TYPE=passthrough
@@ -98,6 +99,7 @@ LABEL io.k8s.display-name="NVIDIA Driver Container"
9899
LABEL name="NVIDIA Driver Container"
99100
LABEL vendor="NVIDIA"
100101
LABEL version="${DRIVER_VERSION}"
102+
LABEL vcs-ref="${GIT_COMMIT}"
101103
LABEL release="N/A"
102104
LABEL summary="Provision the NVIDIA driver through containers"
103105
LABEL description="See summary"

rhel9/precompiled/Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,8 @@ ARG BUILD_ARCH
9393
ARG TARGET_ARCH
9494
ENV TARGETARCH=${TARGET_ARCH}
9595

96+
ARG GIT_COMMIT
97+
9698
# Force using provided RHSM registration
9799
ENV SMDEV_CONTAINER_OFF=1
98100

@@ -179,6 +181,7 @@ LABEL io.k8s.display-name="NVIDIA Driver Container"
179181
LABEL name="NVIDIA Driver Container"
180182
LABEL vendor="NVIDIA"
181183
LABEL version="${DRIVER_VERSION}"
184+
LABEL vcs-ref="${GIT_COMMIT}"
182185
LABEL release="${KERNEL_VERSION}-${OS_TAG}"
183186
LABEL summary="Provision the NVIDIA driver through containers"
184187
LABEL description="See summary"

rhel9/precompiled/Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
GIT_COMMIT ?= $(shell git describe --match="" --dirty --long --always --abbrev=40 2> /dev/null || echo "")
2+
13
RHEL_VERSION ?= 9.4
24
RHEL_VERSION_MAJOR = $(shell echo "${RHEL_VERSION}" | awk -F. '{print $$1}')
35

@@ -70,6 +72,7 @@ image: rhsm-register
7072
--build-arg DRIVER_STREAM_TYPE=${DRIVER_STREAM_TYPE} \
7173
--build-arg BASE_URL=${BASE_URL} \
7274
--build-arg OS_TAG=${OS_TAG} \
75+
--build-arg GIT_COMMIT=${GIT_COMMIT} \
7376
--tag ${IMAGE_REGISTRY}/${IMAGE_NAME}:${DRIVER_VERSION}-${KERNEL_VERSION_TAG}-${OS_TAG} \
7477
--progress=plain \
7578
--file ${DOCKERFILE} .

0 commit comments

Comments
 (0)