Commit cb2b095
committed
Promote a precompiled tag that is missing an architecture
pushImage skipped the push whenever the destination tag already existed,
and imageExists only asked regctl whether the tag resolved at all.
regctl manifest get --list succeeds for any manifest list, no matter
which platforms it contains, and FORCE_PUSH is not set anywhere in this
repository, so the skip always won.
That is harmless while a distribution is amd64 only, but ubuntu24.04 and
now ubuntu26.04 build both architectures. Once an amd64-only tag existed
at the destination, the arm64 instance could never be published: every
later run saw the tag, skipped, and reported success.
The check now probes each platform the build targets with regctl
manifest get --platform, which fails when the manifest list has no entry
for it, and pushes when any of them is missing. push runs as a separate
invocation from build, so the platform set has to be recomputed rather
than carried over; both paths now read it from targetPlatforms so they
cannot disagree about which distributions and kernel flavors are
multi-arch.
Distributions that stay single-arch keep the old behaviour, since
targetPlatforms is empty for them and only the tag existence check runs.
Signed-off-by: Abrar Shivani <ashivani@nvidia.com>1 parent ba64f09 commit cb2b095
1 file changed
Lines changed: 22 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
49 | 57 | | |
50 | 58 | | |
51 | 59 | | |
| |||
63 | 71 | | |
64 | 72 | | |
65 | 73 | | |
66 | | - | |
| 74 | + | |
67 | 75 | | |
68 | 76 | | |
69 | 77 | | |
| |||
89 | 97 | | |
90 | 98 | | |
91 | 99 | | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
92 | 111 | | |
93 | 112 | | |
94 | 113 | | |
| |||
0 commit comments