Skip to content

Commit e2b56ac

Browse files
committed
remove explicit permissions from the image yaml file
Signed-off-by: Karthikeyan Valliyurnatt <kvalliyurnat@nvidia.com>
1 parent 2e153ce commit e2b56ac

1 file changed

Lines changed: 13 additions & 22 deletions

File tree

.github/workflows/image.yaml

Lines changed: 13 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ on:
2222
- "pull-request/[0-9]+"
2323
- release-*
2424

25-
permissions:
26-
contents: read
27-
packages: write
28-
2925
jobs:
3026
image:
3127
runs-on: linux-${{ matrix.arch }}-cpu4
@@ -34,11 +30,11 @@ jobs:
3430
arch:
3531
- amd64
3632
- arm64
37-
driver:
33+
driver: &driver-versions
3834
- 580.178.04
3935
- 595.91.07
4036
- 610.57.04
41-
dist:
37+
dist: &distributions
4238
- ubuntu22.04
4339
- ubuntu24.04
4440
- ubuntu26.04
@@ -50,7 +46,7 @@ jobs:
5046
- rocky10
5147
ispr:
5248
- ${{github.event_name == 'pull_request'}}
53-
exclude:
49+
exclude: &unsupported-images
5450
- dist: ubuntu26.04
5551
driver: 580.178.04
5652
fail-fast: false
@@ -103,6 +99,12 @@ jobs:
10399
if: github.actor != 'dependabot[bot]'
104100
needs: image
105101
runs-on: linux-amd64-cpu4
102+
strategy:
103+
matrix:
104+
driver: *driver-versions
105+
dist: *distributions
106+
exclude: *unsupported-images
107+
fail-fast: false
106108
steps:
107109
- name: Calculate manifest vars
108110
run: |
@@ -121,21 +123,10 @@ jobs:
121123
- name: Create multi-architecture manifest
122124
run: |
123125
IMAGE_NAME="ghcr.io/${LOWERCASE_REPO_OWNER}/driver"
124-
DRIVERS=(580.178.04 595.91.07 610.57.04)
125-
DISTRIBUTIONS=(ubuntu22.04 ubuntu24.04 ubuntu26.04 rhel8 rhel9 rhel10 rocky8 rocky9 rocky10)
126-
127-
for DRIVER in "${DRIVERS[@]}"; do
128-
for DIST in "${DISTRIBUTIONS[@]}"; do
129-
if [[ "$DRIVER" == "580.178.04" && "$DIST" == "ubuntu26.04" ]]; then
130-
continue
131-
fi
132-
133-
docker buildx imagetools create \
134-
--tag "${IMAGE_NAME}:${COMMIT_SHORT_SHA}-${DRIVER}-${DIST}" \
135-
"${IMAGE_NAME}:${COMMIT_SHORT_SHA}-amd64-${DRIVER}-${DIST}" \
136-
"${IMAGE_NAME}:${COMMIT_SHORT_SHA}-arm64-${DRIVER}-${DIST}"
137-
done
138-
done
126+
docker buildx imagetools create \
127+
--tag "${IMAGE_NAME}:${COMMIT_SHORT_SHA}-${{ matrix.driver }}-${{ matrix.dist }}" \
128+
"${IMAGE_NAME}:${COMMIT_SHORT_SHA}-amd64-${{ matrix.driver }}-${{ matrix.dist }}" \
129+
"${IMAGE_NAME}:${COMMIT_SHORT_SHA}-arm64-${{ matrix.driver }}-${{ matrix.dist }}"
139130
140131
pre-compiled:
141132
runs-on: linux-amd64-cpu4

0 commit comments

Comments
 (0)