[Helm] Supports HostNetwork Mode for each components - #1365
Conversation
ccb3b11 to
40d61f2
Compare
|
@elezar Hello. Please review this pr? |
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
|
@elezar Hi! I'd appreciate it if you could take a look at this PR when you get a moment. |
|
Thanks @ssup2 . Can you please also add default value to values.yaml so that its easier to find what one can set. So something like: Similar change for gfd and mps as well. |
There was a problem hiding this comment.
Pull request overview
Adds optional per-component HostNetwork support to the Helm chart so daemon pods can run on the node network and avoid allocating pod IPs in non-overlay environments.
Changes:
- Add
hostNetwork: true+dnsPolicy: ClusterFirstWithHostNetto the device plugin DaemonSet whendevicePlugin.enableHostNetworkis set. - Add
hostNetwork: true+dnsPolicy: ClusterFirstWithHostNetto the GFD DaemonSet whengfd.enableHostNetworkis set. - Add
hostNetwork: true+dnsPolicy: ClusterFirstWithHostNetto the MPS control daemon DaemonSet whenmps.enableHostNetworkis set.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| deployments/helm/nvidia-device-plugin/templates/daemonset-device-plugin.yml | Conditionally enables host networking for the device plugin pod. |
| deployments/helm/nvidia-device-plugin/templates/daemonset-gfd.yml | Conditionally enables host networking for the GFD pod. |
| deployments/helm/nvidia-device-plugin/templates/daemonset-mps-control-daemon.yml | Conditionally enables host networking for the MPS control daemon pod. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Jungsub Shin <supsup5642@gmail.com>
|
Gentle reminder @ssup2 . Please update the values.yaml with default values so that its easier to find how it can be configured. |
Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
|
/ok to test 20f2c29 |
This PR adds support for hostNetwork mode in the Helm Chart.
Using Host Network mode can be useful in environments where the host and pods share the same network CIDR (non-overlay network), as it prevents unnecessary IP allocation for daemon pods, thereby reducing overall IP usage. This option is beneficial in cloud environments such as AWS, Azure, and GCP.