parseBody() replaces Session parameters with form parameters in method POST

[matthieu-labas]

When serving a POST from such a form (enctype being the default application/x-www-form-urlencoded):

<form method="post" action="dopost?file=afile_somewhere">
    <input type="text" name="file" value="/tmp/foo.txt" />
    <input type="submit" />
</form>

public Response serve(IHTTPSession session) {
    System.out.println("Before: "+session.getParms());
    if (session.getMethod() == Method.POST) {
        Map<String,String> fics = new HashMap<>();
        parseBody(fics);
        System.out.println("After: "+session.getParms());
    }
}

will show:

Before: {file=afile_somewhere}
After: {file=/tmp/foo.txt}

[matthieu-labas]

That is because in parseBody(), we call decodeParms(postLine, this.parms); if content type is application/x-www-form-urlencoded (which is the default for <form> elements, see NanoHTTPD.java:1179) which overwrites URL parameters.

I suggest passing an extra Map<String,String> to parseBody(), which would receive those parameters. I can provide a pull-request.

It is not critical as the workaround is easy: create a local copy of session.getParms() before calling parseBody().

[LordFokas]

That explains #363 I'll be marking as duplicate and closing as this one explains everything better.

[LordFokas]

Marked as in-progress because of #366