Improve messaging when NSRDB Data Query fails

Author: cpaulgilman

deploy/runtime/ui/Solar Resource Download.json

@@ -698,6 +698,8 @@
         "\trefresh();\r",
         "}\r",
         "\r",
+        "// NSRDB Download Functions Start Here //////\r",
+        "\r",
         "// check JSON returned by a call to NSRDB Data Query for a valid response\r",
         "function nsrdb_query_json_check( json_str ) {\r",
         "\tvar = json_read( json_str );\r",
@@ -725,14 +727,14 @@
         "\t\t\t\tif ( strpos( lower(var.code), 'api' ) > -1 ) { msg += 'See private.h to set API keys.'; }\r",
         "\t\t\t}\t\r",
         "\t\t}\r",
-        "\t\t// some locations are not covered by the NSRDB, e.g., Anchorage AK\r",
+        "\t\t// some locations are not covered by the NSRDB\r",
         "\t\tif ( var.outputs == null ) {\r",
         "\t\t\tjson_ok = false;\r",
-        "\t\t\tmsg += 'NSRDB Data Query returns no data (outputs = null).\\n\\nSee https://sam.nrel.gov/weather for links to other data sources.\\n';\r",
+        "\t\t\tmsg += 'NSRDB Data Query returns no data (outputs = null) for this location.\\n\\nSee https://sam.nrel.gov/weather for links to other data sources.\\n';\r",
         "\t\t}\r",
         "\t\telseif ( var.outputs == [] ) {\r",
         "\t\t\tjson_ok = false;\r",
-        "\t\t\tmsg += 'NSRDB Data Query returns no data (outputs = []).\\n\\nSee https://sam.nrel.gov/weather for links to other data sources.\\n';\r",
+        "\t\t\tmsg += 'NSRDB Data Query returns no data (outputs = []) for this location.\\n\\nSee https://sam.nrel.gov/weather for links to other data sources.\\n';\r",
         "\t\t}\r",
         "\t}\r",
         "\t// NSRDB API service could be down\r",
@@ -892,6 +894,7 @@
         "\t}\r",
         "\tok_test = ( lat != null && lon != null && dataset_ok == true );\r",
         "\t//msgbox('Debug\\nok_test = ' + ok_test + '\\nlat = ' + lat\t+ '\\nlon = ' + lon + '\\ndataset_ok = ' + dataset_ok );\r",
+        "\t//msgbox('Debug\\nmsg = ' + msg);\r",
         "\treturn { 'name' = name , 'msg' = msg , 'url' = url, 'years' = years , 'ok' = ok_test };\r",
         "}\r",
         "\r",
@@ -993,9 +996,11 @@
         "\t\twrite_line( flog, 'Location ' + to_string(n+1) + ' of ' + #coordinate_list + ': ' + coordinate_list[n]  + '');\r",
         "\t\twrite_line( flog, '----------------------------------------------------------\\n');\t\r",
         "\t\tdataset[n] = nsrdb_query( lat, lon, download_option == TMY );\r",
+        "\t\t//msgbox('Debug\\ndataset[n] = ' + dataset[n]);\r",
         "\t\tif ( !dataset[n].ok ) {\r",
         "\t\t\twrite_line( flog, dataset[n].msg + '\\n');\r",
-        "\t\t\tprogressbar(pb, {'message' = dataset[n].msg, 'value'= pb_count});\r",
+        "\t\t\tprogressbar(pb, {'message' = 'NSRDB Data Query failed.', 'value'= pb_count});\r",
+        "\t\t\tmsgbox('NSRDB Data Query Failed.\\n' + dataset[n].msg);\r",
         "\t\t\tcontinue;\r",
         "\t\t}\t\r",
         "\t\tif ( download_option == TMY ) { // this needs to work for both nsrdb-GOES-tmy-v4-0-0 and suny-india-tmy\r",