Hercules generally uses the convention that the time stamp time_utc refers to the start of the period of record. However, in the case of solar, it would be more accurate if the mid-point was used so that solar libraries like pysam which use time for computing solar altitude use something more reflective of the average. My proposed fix would be:
- Either in the solar base class or in individuals, compute/declare a mid-time array and supply that to pysam
- Clarify
time_utc in the docs as always referring to the start time of a time step and note that solar modules will not pass this value directly but will instead determine the mid-point time of each entry.
@genevievestarke does that sound good to you? @elenya-grant is this similar to H2I method?
Hercules generally uses the convention that the time stamp
time_utcrefers to the start of the period of record. However, in the case of solar, it would be more accurate if the mid-point was used so that solar libraries like pysam which use time for computing solar altitude use something more reflective of the average. My proposed fix would be:time_utcin the docs as always referring to the start time of a time step and note that solar modules will not pass this value directly but will instead determine the mid-point time of each entry.@genevievestarke does that sound good to you? @elenya-grant is this similar to H2I method?