Codacy fixes + enable ASan + few updated FFIs

Author: NicusorN5

3DRadSpace/3DRadSpace_CSharp/Internal/ScriptManager.cs

@@ -230,40 +230,43 @@ public static byte CompileScript(IntPtr scriptPath, IntPtr className)
                 return 0;
             }
 
-            var result = CsCompiler.CompileFromFile(path);
+			var result = CsCompiler.CompileFromFile(path);
 
-            if (!result.Success)
-            {
-                string errors = string.Join("\n", result.Errors);
-                PrintWarning($"Script compilation failed:\n{errors}");
-                return 0;
-            }
+			if (!result.Success)
+			{
+				string errors = string.Join("\n", result.Errors);
+				PrintWarning($"Script compilation failed:\n{errors}");
+				result.Unload();
+				return 0;
+			}
 
-            // Try to create an instance
-            object? instance;
-            try
-            {
-                instance = result.CreateInstance(classNameStr);
-            }
-            catch (Exception ex)
-            {
-                PrintWarning($"Failed to create instance: {ex.Message}");
-                result.Unload();
-                return 0;
-            }
+			// Try to create an instance
+			object? instance;
+			try
+			{
+				instance = result.CreateInstance(classNameStr);
+			}
+			catch (Exception ex)
+			{
+				PrintWarning($"Failed to create instance: {ex.Message}");
+				result.Unload();
+				return 0;
+			}
 
-            if (instance == null)
-            {
-                PrintWarning("Failed to create script instance");
-                result.Unload();
-                return 0;
-            }
-        }
-        catch (Exception ex)
-        {
-            PrintWarning($"Exception in LoadScript: {ex.Message}");
-            return 0;
-        }
+			if (instance == null)
+			{
+				PrintWarning("Failed to create script instance");
+				result.Unload();
+				return 0;
+			}
+
+			result.Unload();
+		}
+		catch (Exception ex)
+		{
+			PrintWarning($"Exception in CompileScript: {ex.Message}");
+			return 0;
+		}
 
 		return 1;
     }

3DRadSpace/3DRadSpace_Editor_WindowsDX11/CMakeLists.txt

@@ -25,7 +25,7 @@ if(MSVC)
 
 	#enable address sanitizer if using a debug configuration
 	if(CMAKE_BUILD_TYPE STREQUAL "Debug")
-		#target_compile_options(3DRadSpace.Editor PRIVATE "/fsanitize=address")
+		target_compile_options(3DRadSpace.Editor PRIVATE "/fsanitize=address")
 	endif()
 endif()
 

3DRadSpace/Engine3DRadSpace/Audio/CMakeLists.txt

@@ -22,7 +22,7 @@ if(MSVC)
 
 	#enable address sanitizer if using a debug configuration
 	if(CMAKE_BUILD_TYPE STREQUAL "Debug")
-		#target_compile_options(3DRadSpace.Audio PRIVATE "/fsanitize=address")
+		target_compile_options(3DRadSpace.Audio PRIVATE "/fsanitize=address")
 	endif()
 
 	target_compile_definitions(3DRadSpace.Audio PRIVATE [[E3DRSP_AUDIO_EXPORT=__declspec(dllexport)]])

3DRadSpace/Engine3DRadSpace/Content/Assets/CMakeLists.txt

@@ -33,7 +33,7 @@ if(MSVC)
 
 	#enable address sanitizer if using a debug configuration
 	if(CMAKE_BUILD_TYPE STREQUAL "Debug")
-		#target_compile_options(3DRadSpace.Content.Assets PRIVATE "/fsanitize=address")
+		target_compile_options(3DRadSpace.Content.Assets PRIVATE "/fsanitize=address")
 	endif()
 
 	target_compile_definitions(3DRadSpace.Content.Assets PRIVATE [[E3DRSP_CONTENT_ASSETS_EXPORT=__declspec(dllexport)]])

3DRadSpace/Engine3DRadSpace/Content/CMakeLists.txt

@@ -25,7 +25,7 @@ if(MSVC)
 
 	#enable address sanitizer if using a debug configuration
 	if(CMAKE_BUILD_TYPE STREQUAL "Debug")
-		#target_compile_options(3DRadSpace.Content PRIVATE "/fsanitize=address")
+		target_compile_options(3DRadSpace.Content PRIVATE "/fsanitize=address")
 	endif()
 
 	target_compile_definitions(3DRadSpace.Content PRIVATE [[E3DRSP_CONTENT_EXPORT=__declspec(dllexport)]])

3DRadSpace/Engine3DRadSpace/Content/ContentManager.cpp

@@ -106,4 +106,9 @@ size_t ContentManager::Count() const noexcept
 IGraphicsDevice* ContentManager::GetDevice() const noexcept
 {
 	return _owner->GetService<IGraphicsDevice>({});
+}
+
+IAsset* ContentManager::At(unsigned id) const
+{
+	return _assets[id].Entry.get();
 }

3DRadSpace/Engine3DRadSpace/Content/ContentManager.hpp

@@ -186,7 +186,14 @@ namespace Engine3DRadSpace::Content
 		/// <param name="ref">Asset reference ID</param>
 		/// <returns>Pointer to the asset of type T</returns>
 		template<AssetType T>
-		T *operator[](AssetID<T> ref);
+		T *operator[](AssetID<T> ref) const;
+
+		/// <summary>
+		/// Returns an pointer to the asset associated with the given reference ID.
+		/// </summary>
+		/// <param name="ref">Asset reference ID</param>
+		/// <returns>Pointer to the asset</returns>
+		IAsset* At(unsigned ref) const;
 
 		/// <summary>
 		/// Returns the path an asset with the specified ID was loaded from.
@@ -284,7 +291,7 @@ namespace Engine3DRadSpace::Content
 	}
 
 	template<AssetType T>
-	inline T* ContentManager::operator[](AssetID<T> ref)
+	inline T* ContentManager::operator[](AssetID<T> ref) const
 	{
 		return dynamic_cast<T*>(_assets[ref].Entry.get());
 	}

3DRadSpace/Engine3DRadSpace/Core/CMakeLists.txt

@@ -37,7 +37,7 @@ if(MSVC)
 
 	#enable address sanitizer if using a debug configuration
 	if(CMAKE_BUILD_TYPE STREQUAL "Debug")
-		#target_compile_options(3DRadSpace.Core PRIVATE "/fsanitize=address")
+		target_compile_options(3DRadSpace.Core PRIVATE "/fsanitize=address")
 	endif()
 
 	#Define library specific library export macro

3DRadSpace/Engine3DRadSpace/FFI/Audio/AudioEngine.h

@@ -1,5 +1,6 @@
 #pragma once
 #include "IAudioEngine.h"
+#include "AudioError.h"
 
 #ifdef __cplusplus
 extern "C"

3DRadSpace/Engine3DRadSpace/FFI/Audio/AudioError.h

@@ -0,0 +1,30 @@
+#pragma once
+
+enum E3DRSP_AudioError
+{
+	/// <summary>
+	/// No error.
+	/// </summary>
+	E3DRSP_AudioError_None = 0,
+	/// <summary>
+	/// Invalid name parameter.
+	/// </summary>
+	E3DRSP_AudioError_BadID,
+	/// <summary>
+	/// Invalid enum parameter value.
+	/// </summary>
+	E3DRSP_AudioError_InvalidEnum,
+	/// <summary>
+	/// Invalid value parameter.
+	/// </summary>
+	E3DRSP_AudioError_InvalidValue,
+	/// <summary>
+	/// The function was called in an invalid context.
+	/// </summary>
+	E3DRSP_AudioError_InvalidOperation,
+	/// <summary>
+	/// Not enough memory to perform the operation.
+	/// </summary>
+	E3DRSP_AudioError_OutOfMemory,
+	E3DRSP_AudioError_Unspecified = 0x7FFFFFFF,
+};