Fix multiple memory issues. Meshes with enabled shadow mapping are invisible.

- Fix use-after-free when an Camera object is selected, then the editor is closed
- Fix heap-buffer-overrun inside ForwardRenderer by updating owner references of RenderingManager by using an custom move ctor
- Properly set vertex topology in ForwardRenderer + ShadowMapRenderer
- Fix memory leak in RenderingManager::Execute (the meshpart list wasn't cleared each draw cycle)
- Constant buffer mem copy corectness
- Fix memcpy failed assert when selecting an object: The matrix structure is optimised out of the pixel shader
- Fixed the wireframe selection effect being hiddern by swapping the drawing order of the mesh and wireframe

Author: NicusorN5

3DRadSpace/3DRadSpace_Editor_WindowsDX11/Frontend/Windows/EditorWindow.cpp

@@ -595,6 +595,7 @@ void EditorWindow::Run()
 		cmd->SetViewport();
 		cmd->Clear(editor->ClearColor);
 		this->editor->Draw3D();
+		this->editor->RenderingManager->Execute();
 		this->editor->PostProcesses->ApplyAll();
 		this->editor->Draw2D();
 		cmd->Present();

3DRadSpace/Engine3DRadSpace/Games/Game.hpp

@@ -59,8 +59,8 @@ namespace Engine3DRadSpace
 		std::unique_ptr<Audio::IAudioEngine> Audio;
 		std::unique_ptr<Graphics::Rendering::PostProcessCollection> PostProcesses;
 
-		std::unique_ptr<Objects::ObjectList> Objects;
 		std::unique_ptr<Objects::CameraProvider> Cameras;
+		std::unique_ptr<Objects::ObjectList> Objects;
 
 		IService* RequireService(const std::type_index& type);
 

3DRadSpace/Engine3DRadSpace/Graphics/DirectX11/ShaderBase.cpp

@@ -126,9 +126,10 @@ void ShaderBase::SetData(unsigned index, const void* data, size_t dataSize)
 	if (ptr == nullptr)
 	{
 		constantBuff.Buffer = std::make_unique<std::byte[]>(dataSize);
+		constantBuff.Size = dataSize;
 		ptr = constantBuff.Buffer.get();
 	}
-	memcpy_s(ptr, dataSize, data, dataSize);
+	memcpy_s(ptr, constantBuff.Size, data, dataSize);
 
 	if (handle == nullptr)
 	{

3DRadSpace/Engine3DRadSpace/Graphics/IShader.hpp

@@ -51,6 +51,12 @@ namespace Engine3DRadSpace::Graphics
 			Set(name, &data, sizeof(T));
 		}
 
+		template<typename T>
+		void SetData(const T* data, unsigned index)
+		{
+			SetData(index, data, sizeof(T));
+		}
+
 		virtual std::string_view GetEntryName() const noexcept = 0;
 		virtual const char* GetCompilationErrorsAndWarnings() const noexcept = 0;
 

3DRadSpace/Engine3DRadSpace/Graphics/Rendering/ForwardRenderer.cpp

@@ -157,6 +157,7 @@ void ForwardRenderer::Draw(ModelMeshPart* part, const MaterialDescriptor* materi
 			effect->SetSampler(samplerState.get(), idTexture++);
 	}
 
+	_context->SetTopology(VertexTopology::TriangleList);
 	_context->DrawVertexBufferWithindices(
 		part->GetVertexBuffer(),
 		part->GetIndexBuffer()

3DRadSpace/Engine3DRadSpace/Graphics/Rendering/IRenderer.hpp

@@ -47,5 +47,7 @@ namespace Engine3DRadSpace::Graphics::Rendering
 		virtual bool IsRenderPassTypeSupported(RenderPassType passType) const noexcept = 0;
 
 		virtual ~IRenderer() = default;
+
+		friend class RenderingManager;
 	};
 }

3DRadSpace/Engine3DRadSpace/Graphics/Rendering/RenderingManager.cpp

@@ -14,6 +14,35 @@ RenderingManager::RenderingManager(IGraphicsDevice* device) :
 {
 }
 
+RenderingManager::RenderingManager(RenderingManager&& other) noexcept :
+	_device(other._device),
+	_renderers(std::move(other._renderers)),
+	_meshParts(std::move(other._meshParts))
+{
+	for (auto& renderer : _renderers)
+	{
+		renderer->_owner = this;
+	}
+
+	other._device = nullptr;
+}
+
+RenderingManager& RenderingManager::operator=(RenderingManager&& other) noexcept
+{
+	if (this != &other)
+	{
+		_device = other._device;
+		_renderers = std::move(other._renderers);
+		_meshParts = std::move(other._meshParts);
+		for (auto& renderer : _renderers)
+		{
+			renderer->_owner = this;
+		}
+		other._device = nullptr;
+	}
+	return *this;
+}
+
 void RenderingManager::Add(std::unique_ptr<IRenderer>&& renderPass)
 {
 	_renderers.emplace_back(std::move(renderPass));
@@ -57,6 +86,8 @@ void RenderingManager::Execute()
 
 		renderer->End();
 	}
+
+	_meshParts.clear();
 }
 
 void RenderingManager::Draw(Model3D* model, RenderPassType passType)

3DRadSpace/Engine3DRadSpace/Graphics/Rendering/RenderingManager.hpp

@@ -31,8 +31,8 @@ namespace Engine3DRadSpace::Graphics::Rendering
 		///	<param name="device">Graphics device to use for rendering.</param>
 		RenderingManager(IGraphicsDevice* device);
 
-		RenderingManager(RenderingManager&&) = default;
-		RenderingManager& operator=(RenderingManager&&) = default;
+		RenderingManager(RenderingManager&&) noexcept;
+		RenderingManager& operator=(RenderingManager&&) noexcept;
 
 		/// <summary>
 		/// Emplaces a new renderer of type R with the given arguments.

3DRadSpace/Engine3DRadSpace/Graphics/Rendering/ShadowMapRenderer.cpp

@@ -156,6 +156,7 @@ void ShadowMapRenderer::Draw(ModelMeshPart* part, const MaterialDescriptor* mate
 
 	_shadowMapEffect->SetData<Math::Matrix4x4>(&lvp, 0);
 
+	_context->SetTopology(VertexTopology::TriangleList);
 	_context->DrawVertexBufferWithindices(
 		part->GetVertexBuffer(),
 		part->GetIndexBuffer()

3DRadSpace/Engine3DRadSpace/Graphics/Rendering/ShadowMapRenderer.hpp

@@ -20,7 +20,7 @@ namespace Engine3DRadSpace::Graphics::Rendering
 		void _createShadowStates();
 		void _loadEffect();
 	public:
-		ShadowMapRenderer(RenderingManager* owner);
+		explicit ShadowMapRenderer(RenderingManager* owner);
 
 		/// <summary>
 		/// Defines the size of the shadow map as a multiplier of the screen resolution.