Fix not being able to read empty WAV files

Author: NoahStolk

src/libs/Detach/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 This library uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 0.30.2
+
+### Fixed
+
+- Fixed not being able to read WAV files with empty `data` chunk.
+- `RandomExtensions.Choose` now throws an exception when the `options` argument is empty.
+
 ## 0.30.1
 
 ### Added

src/libs/Detach/Detach.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup Label="Package configuration">
     <PackageId>NoahStolk.Detach</PackageId>
-    <Version>0.30.1</Version>
+    <Version>0.30.2</Version>
   </PropertyGroup>
 
 </Project>

src/libs/Detach/Extensions/RandomExtensions.cs

@@ -106,6 +106,9 @@ public static double RandomDouble(this Random random, double minValue, double ma
 	/// <returns>The randomly chosen item.</returns>
 	public static T Choose<T>(this Random random, params Span<T> options)
 	{
+		if (options.Length == 0)
+			throw new ArgumentException("options cannot be empty", nameof(options));
+
 		return options[random.Next(options.Length)];
 	}
 

src/libs/Detach/Parsers/Sound/WavFormat/WaveParser.cs

@@ -62,7 +62,7 @@ public static SoundData Parse(byte[] fileContents)
 		if (blockAlign != expectedBlockAlign)
 			throw new WaveParseException($"Expected block align to be {expectedBlockAlign} (got {blockAlign}).");
 
-		while (br.BaseStream.Position < br.BaseStream.Length - (DataHeader.Length + sizeof(int)))
+		while (br.BaseStream.Position <= br.BaseStream.Length - (DataHeader.Length + sizeof(int)))
 		{
 			ReadOnlySpan<byte> dataHeader = br.ReadBytes(4);
 			if (!dataHeader.SequenceEqual(DataHeader))

src/tests/Detach.Tests.Unit/Resources/Empty.wav

@@ -12,6 +12,7 @@ public sealed class WaveParserTests
 	[DataRow("Sample1.wav", (short)1, 11000, 11000, (short)1, (short)8, 2208, 2208, 0.2)]
 	[DataRow("Sample2.wav", (short)1, 11025, 22050, (short)2, (short)16, 61544, 30772, 2.791)]
 	[DataRow("Sample3.wav", (short)1, 44100, 88200, (short)2, (short)16, 18760, 9380, 0.221)]
+	[DataRow("Empty.wav", (short)2, 44100, 176400, (short)4, (short)16, 0, 0, 0.000)]
 	public void TestWaveParse(string fileName, short expectedChannels, int expectedSampleRate, int expectedByteRate, short expectedBlockAlign, short expectedBitsPerSample, int expectedDataSize, int expectedSampleCount, double expectedLengthInSeconds)
 	{
 		byte[] bytes = File.ReadAllBytes(ResourceUtils.GetResourcePath(fileName));