build(edr_napi): move dyn-symbols to dev-dependencies (#1533) (#1534)

Author: nebasuke

crates/edr_napi/Cargo.toml

@@ -46,11 +46,8 @@ mimalloc = { version = "0.1.39", default-features = false, features = [
     "local_dynamic_tls",
 ] }
 # The `async` feature ensures that a tokio runtime is available.
-# `dyn-symbols` lets test binaries that keep napi code alive link outside a Node host.
-# TODO(#1533): gate `dyn-symbols` behind a non-default feature so it stays out of the published addon.
 napi = { version = "3", default-features = false, features = [
     "async",
-    "dyn-symbols",
     "error_anyhow",
     "napi8",
     "serde-json",
@@ -95,6 +92,12 @@ openssl-sys = { version = "0.9.93", features = ["vendored"] }
 # napi-build has no v3 release; 2.x is current for napi 3.
 napi-build = "2.3"
 
+[dev-dependencies]
+# `dyn-symbols` resolves N-API symbols at runtime so standalone test binaries
+# link without a Node host. Kept out of [dependencies] so the published addon
+# links against Node's symbols directly and doesn't ship libloading resolution.
+napi = { version = "3", default-features = false, features = ["dyn-symbols"] }
+
 [features]
 op = ["dep:edr_op"]
 scenarios = ["dep:edr_scenarios", "dep:rand"]

crates/edr_napi_core/Cargo.toml

@@ -27,13 +27,8 @@ edr_solidity_tests.workspace = true
 edr_transaction.workspace = true
 foundry-cheatcodes.workspace = true
 itertools = { version = "0.15.0", default-features = false }
-# `dyn-symbols` (an upstream default) resolves N-API symbols at runtime via
-# libloading instead of link-time externs. Without it, this crate's unit-test
-# binary fails to link: the tests keep `napi::Error` paths alive, and its Drop
-# references N-API symbols that only a Node host provides.
 napi = { version = "3", default-features = false, features = [
     "async",
-    "dyn-symbols",
     "error_anyhow",
     "napi8",
     "serde-json",
@@ -44,6 +39,13 @@ serde_json.workspace = true
 thiserror.workspace = true
 tokio.workspace = true
 
+[dev-dependencies]
+# `dyn-symbols` resolves N-API symbols at runtime so this crate's unit-test
+# binary links without a Node host: the tests keep `napi::Error` Drop paths
+# alive, which reference N-API symbols only a Node host provides. Kept out of
+# [dependencies] so nothing downstream ships libloading resolution.
+napi = { version = "3", default-features = false, features = ["dyn-symbols"] }
+
 [features]
 tracing = [
     "edr_chain_l1/tracing",