Skip to content

Commit 5feb88a

Browse files
Add stale prs (kptdev#1053)
* Adding rules about stale pr-s Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> * Adding approval requests Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> * Apply suggestions from code review Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Assisted-by: GitHub Copilot: Claude Haiku 4.5 Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 parent b8d69c0 commit 5feb88a

1 file changed

Lines changed: 14 additions & 3 deletions

File tree

  • docs/content/en/docs/12_contributing/code-contribution

docs/content/en/docs/12_contributing/code-contribution/_index.md

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -192,21 +192,32 @@ The PR will automatically update with your new commits.
192192

193193
## Reviews of Your PR
194194

195-
Before your PR is merged, it must be reviewed by community members and maintainers. Generally, in order to make the best
196-
use of their time, they will review your PR when:
195+
Before your PR is merged, it must be reviewed by community members and maintainers. Generally, in
196+
order to make the best use of their time, they will review your PR when:
197197

198198
1. The code including the code changes in your PR is compiling and building
199199
2. The documentation is building and verified
200200
3. All lint checks are passing
201201
4. SonarCloud quality checks such as code coverage levels are passing
202-
5. The comments from the first run of AI on the commit of the PR are addressed (Further re-runs of AI are optional)
202+
5. The comments from the first run of AI on the commit of the PR are addressed (Further re-runs of
203+
AI are optional)
204+
205+
All PRs should be approved by at least one member of the
206+
[contributors](https://github.com/orgs/kptdev/teams/contributors) team and one member of the
207+
[maintainers](https://github.com/orgs/kptdev/teams/maintainers) team, have all checks passing, and have all discussions resolved before merge.
208+
203209

204210
{{% alert title="Note" color="primary" %}}
205211
If you are having difficulty in getting tests to pass, need guidance in how to address an AI-generated comment, or
206212
want to request an exception on a quality metric such as code coverage, please add a comment on your PR and the
207213
community members and maintainers will consider your request.
208214
{{% /alert %}}
209215

216+
### Stale PRs
217+
218+
If review comments on a PR are not addressed for more than two weeks, maintainers may close the PR.
219+
A closed PR can be reopened at any time to continue the work.
220+
210221
## Rebase on Latest Main
211222

212223
If your PR becomes outdated with the main branch:

0 commit comments

Comments
 (0)