Skip to content

Commit 20f8259

Browse files
committed
Resolve Copilot's review:
Do not require phpcompatibility/php-compatibility. magento/magento-coding-standard pulls magento/php-compatibility-fork, which declares `replace: phpcompatibility/php-compatibility`, so the real package can never be installed and the entry only implied otherwise. The php-compat CI job installs the real sniffs in an isolated directory instead
1 parent 55a69b3 commit 20f8259

3 files changed

Lines changed: 6 additions & 9 deletions

File tree

.github/workflows/action.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,10 +182,10 @@ jobs:
182182
name: composer-zip-archive
183183
path: archive.zip
184184

185-
# Magento 2.4.8 pins php to ~8.2.0||~8.3.0||~8.4.0, so a normal install cannot
186-
# run on 8.5 yet. This lane installs with the platform requirement ignored and
187-
# only runs PHPCompatibility, which parses source and never executes Magento,
188-
# so the module stays verified 8.5-clean ahead of Magento allowing 8.5.
185+
# Magento 2.4.8 pins php to ~8.2.0||~8.3.0||~8.4.0, so a normal Magento install cannot
186+
# run on 8.5 yet. This lane runs on PHP 8.5 without installing Magento; it only lints the
187+
# repository and runs PHPCompatibility in an isolated directory to keep the module 8.5-clean
188+
# ahead of Magento allowing 8.5.
189189
php-compat:
190190
name: PHP 8.2-8.5 Compatibility
191191
runs-on: ubuntu-latest

composer.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
"magento/magento-coding-standard": "^38",
1212
"phan/phan": "^6.0",
1313
"phpmd/phpmd": "^2.15",
14-
"phpcompatibility/php-compatibility": "^10.0@alpha",
1514
"drenso/phan-extensions": "^3.5",
1615
"phing/phing": "^3.0",
1716
"squizlabs/php_codesniffer": "^3.13",

composer.lock

Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)