Skip to content

Commit c97c108

Browse files
rootclaude
andcommitted
fix: make health probes use named ports and improve Makefile idempotency
- Change all health probes to use 'port: http' instead of hardcoded 8000 - Makes chart robust to service.port configuration changes - Update install-all and upgrade-all to use 'helm upgrade --install' - Ensures batch operations are idempotent and won't fail on re-runs - Add --create-namespace to upgrade-all for consistency - Improve overall chart reliability and user experience 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent b67d611 commit c97c108

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ install-all:
7575
@for dir in helm/*/; do \
7676
CHART=$$(basename $$dir); \
7777
echo "Installing chart: $$CHART"; \
78-
helm install $$CHART helm/$$CHART \
78+
helm upgrade --install $$CHART helm/$$CHART \
7979
--namespace $(NAMESPACE) \
8080
--create-namespace \
8181
--values helm/$$CHART/values.yaml; \
@@ -87,8 +87,9 @@ upgrade-all:
8787
@for dir in helm/*/; do \
8888
CHART=$$(basename $$dir); \
8989
echo "Upgrading chart: $$CHART"; \
90-
helm upgrade $$CHART helm/$$CHART \
90+
helm upgrade --install $$CHART helm/$$CHART \
9191
--namespace $(NAMESPACE) \
92+
--create-namespace \
9293
--values helm/$$CHART/values.yaml; \
9394
done
9495

helm/chat-service/values.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,22 +85,22 @@ resources:
8585
startupProbe:
8686
httpGet:
8787
path: /health
88-
port: 8000
88+
port: http
8989
initialDelaySeconds: 10
9090
periodSeconds: 5
9191
timeoutSeconds: 3
9292
failureThreshold: 6
9393
livenessProbe:
9494
httpGet:
9595
path: /health
96-
port: 8000
96+
port: http
9797
periodSeconds: 30
9898
timeoutSeconds: 5
9999
failureThreshold: 3
100100
readinessProbe:
101101
httpGet:
102102
path: /health
103-
port: 8000
103+
port: http
104104
periodSeconds: 10
105105
timeoutSeconds: 3
106106
failureThreshold: 2

0 commit comments

Comments
 (0)