handle date pointers

Author: pierre-b

liquid/standardfilters_test.go

@@ -3,6 +3,7 @@ package liquid
 import (
 	"strings"
 	"testing"
+	"time"
 )
 
 func TestStandardFiltersSize(t *testing.T) {
@@ -1535,3 +1536,14 @@ func TestIsTruthyTypedCollections(t *testing.T) {
 		})
 	}
 }
+
+func TestStandardFilters_Date_WithPointerToTime(t *testing.T) {
+	now := time.Date(2024, 3, 7, 12, 0, 0, 0, time.UTC)
+	ptr := &now
+	sf := &StandardFilters{}
+	result := sf.Date(ptr, "%b %d, %Y")
+	expected := "Mar 07, 2024"
+	if result != expected {
+		t.Errorf("Date(*time.Time) = %v, expected %v", result, expected)
+	}
+}

liquid/utils.go

@@ -171,11 +171,19 @@ func ToNumber(obj interface{}) interface{} {
 
 // ToDate converts a value to a time.Time.
 func ToDate(obj interface{}) *time.Time {
-	// If it already has a Strftime method (time.Time), return it
+	// Handle time.Time directly
 	if t, ok := obj.(time.Time); ok {
 		return &t
 	}
 
+	// Handle *time.Time pointer (NEW - fixes the bug)
+	if t, ok := obj.(*time.Time); ok {
+		if t == nil {
+			return nil
+		}
+		return t
+	}
+
 	switch v := obj.(type) {
 	case string:
 		if v == "" {

liquid/utils_test.go

@@ -86,6 +86,8 @@ func TestToDate(t *testing.T) {
 		wantNil bool
 	}{
 		{"time.Time", now, false},
+		{"*time.Time pointer", &now, false},
+		{"nil *time.Time pointer", (*time.Time)(nil), true},
 		{"now string", "now", false},
 		{"today string", "today", false},
 		{"unix timestamp string", "1609459200", false},
@@ -102,6 +104,27 @@ func TestToDate(t *testing.T) {
 	}
 }
 
+func TestToDate_PointerToTime(t *testing.T) {
+	now := time.Now()
+	ptr := &now
+	got := ToDate(ptr)
+	if got == nil {
+		t.Errorf("ToDate(*time.Time) = nil, expected non-nil")
+		return
+	}
+	if !got.Equal(now) {
+		t.Errorf("ToDate(*time.Time) = %v, expected %v", got, now)
+	}
+}
+
+func TestToDate_NilPointerToTime(t *testing.T) {
+	var ptr *time.Time = nil
+	got := ToDate(ptr)
+	if got != nil {
+		t.Errorf("ToDate(nil *time.Time) = %v, expected nil", got)
+	}
+}
+
 func TestToS(t *testing.T) {
 	tests := []struct {
 		name         string