readme + remove smtp webhook reg

Author: pierre-b

README.md

@@ -58,7 +58,6 @@ Notifuse follows clean architecture principles with clear separation of concerns
 ### Database
 
 - **PostgreSQL**: Primary data storage with Squirrel query builder
-- **Migrations**: Database schema management and versioning
 
 ## 📁 Project Structure
 
@@ -73,8 +72,6 @@ Notifuse follows clean architecture principles with clear separation of concerns
 ├── console/               # React-based admin interface
 ├── notification_center/   # Embeddable notification widget
 ├── pkg/                   # Public packages
-├── docs/                  # Documentation (Mintlify)
-├── homepage/              # Marketing website (Astro)
 └── config/                # Configuration files
 ```
 
@@ -113,29 +110,38 @@ make build
 Notifuse can be configured through environment variables or configuration files:
 
 ```env
-# Database
-DATABASE_URL=postgres://user:password@localhost/notifuse
-
-# Email Providers
-SENDGRID_API_KEY=your_sendgrid_key
-MAILGUN_API_KEY=your_mailgun_key
-AWS_ACCESS_KEY_ID=your_aws_key
-
-# File Storage
-S3_BUCKET=your-bucket-name
-S3_REGION=us-east-1
-
-# Application
-APP_PORT=8080
-APP_ENV=production
+# Server configuration
+SERVER_PORT=4000
+SERVER_HOST=127.0.0.1
+ROOT_EMAIL=your@email.com
+ENVIRONMENT=production
+API_ENDPOINT=https://your_endpoint.website.com
+
+# Database configuration
+DB_HOST=localhost
+DB_PORT=5432
+DB_USER=postgre
+DB_PASSWORD=
+DB_PREFIX=notifuse
+DB_NAME=${DB_PREFIX}_system
+DB_SSLMODE=disable
+
+# System email configuration
+SMTP_HOST=smtp.example.com
+SMTP_PORT=587
+SMTP_USERNAME=your-username
+SMTP_PASSWORD=your-password
+SMTP_FROM=noreply@example.com
+
+# Security configuration
+PASETO_PRIVATE_KEY="generated_private_key_here"
+PASETO_PUBLIC_KEY="generated_public_key_here"
+SECRET_KEY="your_complex_secret_key_here"
 ```
 
 ## 📚 Documentation
 
 - **[Complete Documentation](https://docs.notifuse.com)** - Comprehensive guides and tutorials
-- **[API Reference](https://docs.notifuse.com/api-reference)** - REST API documentation
-- **[Self-Hosting Guide](https://docs.notifuse.com/deployment)** - Deployment and configuration
-- **[Developer Guide](https://docs.notifuse.com/development)** - Contributing and customization
 
 ## 🤝 Contributing
 
@@ -156,7 +162,6 @@ Notifuse is released under the [Elastic License 2.0](LICENSE).
 - **Documentation**: [docs.notifuse.com](https://docs.notifuse.com)
 - **Email Support**: [hello@notifuse.com](mailto:hello@notifuse.com)
 - **GitHub Issues**: [Report bugs or request features](https://github.com/Notifuse/notifuse/issues)
-- **Community**: [Join our Discord](https://discord.gg/notifuse)
 
 ## 🌟 Why Choose Notifuse?
 
@@ -169,4 +174,4 @@ Notifuse is released under the [Elastic License 2.0](LICENSE).
 
 ---
 
-**Ready to get started?** [Try the live demo](https://demo.notifuse.com) or [deploy your own instance](https://docs.notifuse.com/deployment/docker) in minutes.
+**Ready to get started?** [Try the live demo](https://demo.notifuse.com) or [deploy your own instance](https://docs.notifuse.com) in minutes.

internal/service/workspace_service.go

@@ -810,8 +810,8 @@ func (s *WorkspaceService) CreateIntegration(ctx context.Context, workspaceID, n
 		return "", err
 	}
 
-	// If this is an email integration, register webhooks
-	if integrationType == domain.IntegrationTypeEmail && s.webhookRegService != nil {
+	// If this is an email integration, register webhooks (except for SMTP which doesn't support webhooks)
+	if integrationType == domain.IntegrationTypeEmail && s.webhookRegService != nil && provider.Kind != domain.EmailProviderKindSMTP {
 		// Define the events to register
 		eventTypes := []domain.EmailEventType{
 			domain.EmailEventDelivered,
@@ -934,8 +934,8 @@ func (s *WorkspaceService) DeleteIntegration(ctx context.Context, workspaceID, i
 		return fmt.Errorf("integration not found")
 	}
 
-	// Before removing the integration, attempt to unregister webhooks for email integrations
-	if integration.Type == domain.IntegrationTypeEmail && s.webhookRegService != nil {
+	// Before removing the integration, attempt to unregister webhooks for email integrations (except SMTP which doesn't support webhooks)
+	if integration.Type == domain.IntegrationTypeEmail && s.webhookRegService != nil && integration.EmailProvider.Kind != domain.EmailProviderKindSMTP {
 		// Try to get webhook status to check what's registered
 		status, err := s.webhookRegService.GetWebhookStatus(ctx, workspaceID, integrationID)
 		if err != nil {

internal/service/workspace_service_test.go

@@ -778,21 +778,7 @@ func TestWorkspaceService_DeleteWorkspace(t *testing.T) {
 		mockRepo.EXPECT().GetUserWorkspace(ctx, userID, workspaceID).Return(userWorkspace, nil).Times(2)
 		mockRepo.EXPECT().GetByID(ctx, workspaceID).Return(workspace, nil).Times(2)
 
-		// For first integration
-		webhookStatus1 := &domain.WebhookRegistrationStatus{
-			EmailProviderKind: domain.EmailProviderKindSMTP,
-			IsRegistered:      true,
-		}
-		mockWebhookRegService.EXPECT().GetWebhookStatus(ctx, workspaceID, "integration-1").Return(webhookStatus1, nil)
-		mockWebhookRegService.EXPECT().UnregisterWebhooks(ctx, workspaceID, "integration-1").Return(nil)
-
-		// For second integration
-		webhookStatus2 := &domain.WebhookRegistrationStatus{
-			EmailProviderKind: domain.EmailProviderKindSMTP,
-			IsRegistered:      true,
-		}
-		mockWebhookRegService.EXPECT().GetWebhookStatus(ctx, workspaceID, "integration-2").Return(webhookStatus2, nil)
-		mockWebhookRegService.EXPECT().UnregisterWebhooks(ctx, workspaceID, "integration-2").Return(nil)
+		// No webhook operations expected for SMTP integrations
 
 		// Once for each integration deletion
 		mockRepo.EXPECT().Update(ctx, gomock.Any()).Return(nil).Times(2)
@@ -843,13 +829,7 @@ func TestWorkspaceService_DeleteWorkspace(t *testing.T) {
 		mockRepo.EXPECT().GetUserWorkspace(ctx, userID, workspaceID).Return(userWorkspace, nil)
 		mockRepo.EXPECT().GetByID(ctx, workspaceID).Return(workspace, nil)
 
-		// The integration deletion fails
-		webhookStatus := &domain.WebhookRegistrationStatus{
-			EmailProviderKind: domain.EmailProviderKindSMTP,
-			IsRegistered:      true,
-		}
-		mockWebhookRegService.EXPECT().GetWebhookStatus(ctx, workspaceID, "integration-1").Return(webhookStatus, nil)
-		mockWebhookRegService.EXPECT().UnregisterWebhooks(ctx, workspaceID, "integration-1").Return(errors.New("webhook error"))
+		// No webhook operations expected for SMTP integrations
 		// The update fails
 		mockRepo.EXPECT().Update(ctx, gomock.Any()).Return(errors.New("integration delete error"))
 
@@ -984,25 +964,8 @@ func TestWorkspaceService_CreateIntegration(t *testing.T) {
 			return nil
 		})
 
-		// Expect webhook registration call for email integration
+		// No webhook registration expected for SMTP provider
 		mockConfig.APIEndpoint = "https://api.example.com"
-		// Webhook config is provided for reference only, we use gomock.Any() since ID is random
-		_ = &domain.WebhookRegistrationConfig{
-			IntegrationID: "integration123", // This will be a random UUID, so use Any matcher
-			EventTypes: []domain.EmailEventType{
-				domain.EmailEventDelivered,
-				domain.EmailEventBounce,
-				domain.EmailEventComplaint,
-			},
-		}
-		mockWebhookRegService.EXPECT().RegisterWebhooks(
-			ctx,
-			workspaceID,
-			gomock.Any(), // Use Any for the config since integrationID is random
-		).Return(&domain.WebhookRegistrationStatus{
-			EmailProviderKind: domain.EmailProviderKindSMTP,
-			IsRegistered:      true,
-		}, nil)
 
 		integrationID, err := service.CreateIntegration(ctx, workspaceID, integrationName, domain.IntegrationTypeEmail, provider)
 		require.NoError(t, err)
@@ -1328,21 +1291,7 @@ func TestWorkspaceService_DeleteIntegration(t *testing.T) {
 		mockRepo.EXPECT().GetUserWorkspace(ctx, userID, workspaceID).Return(expectedUserWorkspace, nil)
 		mockRepo.EXPECT().GetByID(ctx, workspaceID).Return(expectedWorkspace, nil)
 
-		// Expect webhook status check
-		webhookStatus := &domain.WebhookRegistrationStatus{
-			EmailProviderKind: domain.EmailProviderKindSMTP,
-			IsRegistered:      true,
-			Endpoints: []domain.WebhookEndpointStatus{
-				{
-					URL:    "https://api.example.com/webhooks",
-					Active: true,
-				},
-			},
-		}
-		mockWebhookRegService.EXPECT().GetWebhookStatus(ctx, workspaceID, integrationID).Return(webhookStatus, nil)
-
-		// Expect webhook unregistration
-		mockWebhookRegService.EXPECT().UnregisterWebhooks(ctx, workspaceID, integrationID).Return(nil)
+		// No webhook operations expected for SMTP provider
 
 		mockRepo.EXPECT().Update(ctx, gomock.Any()).DoAndReturn(func(ctx context.Context, workspace *domain.Workspace) error {
 			// Verify the integration was removed from the workspace
@@ -1440,25 +1389,7 @@ func TestWorkspaceService_DeleteIntegration(t *testing.T) {
 		mockRepo.EXPECT().GetUserWorkspace(ctx, userID, workspaceID).Return(expectedUserWorkspace, nil)
 		mockRepo.EXPECT().GetByID(ctx, workspaceID).Return(expectedWorkspace, nil)
 
-		// Expect webhook status check
-		mockWebhookRegService.EXPECT().GetWebhookStatus(ctx, workspaceID, integrationID).Return(&domain.WebhookRegistrationStatus{
-			EmailProviderKind: domain.EmailProviderKindSMTP,
-			IsRegistered:      true,
-			Endpoints: []domain.WebhookEndpointStatus{
-				{
-					URL:    "https://api.example.com/webhooks",
-					Active: true,
-				},
-			},
-		}, nil)
-
-		// Skip logger checks
-
-		// The unregistration fails
-		webhookError := errors.New("failed to unregister webhooks")
-		mockWebhookRegService.EXPECT().UnregisterWebhooks(ctx, workspaceID, integrationID).Return(webhookError)
-
-		// Skip logger checks
+		// No webhook operations expected for SMTP provider
 
 		mockRepo.EXPECT().Update(ctx, gomock.Any()).Return(nil)
 
@@ -1500,11 +1431,7 @@ func TestWorkspaceService_DeleteIntegration(t *testing.T) {
 		mockRepo.EXPECT().GetUserWorkspace(ctx, userID, workspaceID).Return(expectedUserWorkspace, nil)
 		mockRepo.EXPECT().GetByID(ctx, workspaceID).Return(expectedWorkspace, nil)
 
-		// Expect webhook status check
-		mockWebhookRegService.EXPECT().GetWebhookStatus(ctx, workspaceID, integrationID).Return(&domain.WebhookRegistrationStatus{
-			EmailProviderKind: domain.EmailProviderKindSMTP,
-			IsRegistered:      false, // Not registered
-		}, nil)
+		// No webhook operations expected for SMTP provider
 
 		mockRepo.EXPECT().Update(ctx, gomock.Any()).DoAndReturn(func(ctx context.Context, workspace *domain.Workspace) error {
 			// Verify the reference was removed from settings