Fix: Make fromName required in SendEmailProviderRequest

cursoragent · pierre-b · cursoragent · commit dfd20c0bc63e · 2025-10-24T01:44:16.000Z
Co-authored-by: pierre &lt;pierre@bazoge.com&gt;
diff --git a/internal/domain/email_provider.go b/internal/domain/email_provider.go
@@ -300,10 +300,9 @@ func (r *SendEmailProviderRequest) Validate() error {
 	if r.FromAddress == "" {
 		return fmt.Errorf("from address is required")
 	}
-	// FromName is optional - it can be empty and will be set by the email service fallback
-	// if r.FromName == "" {
-	// 	return fmt.Errorf("from name is required")
-	// }
+	if r.FromName == "" {
+		return fmt.Errorf("from name is required")
+	}
 	if r.To == "" {
 		return fmt.Errorf("to address is required")
 	}

Original file line number	Diff line number	Diff line change
`@@ -300,10 +300,9 @@ func (r *SendEmailProviderRequest) Validate() error {`
`300`	`300`	`if r.FromAddress == "" {`
`301`	`301`	`return fmt.Errorf("from address is required")`
`302`	`302`	`}`
`303`		`- // FromName is optional - it can be empty and will be set by the email service fallback`
`304`		`- // if r.FromName == "" {`
`305`		`- // return fmt.Errorf("from name is required")`
`306`		`- // }`
	`303`	`+ if r.FromName == "" {`
	`304`	`+ return fmt.Errorf("from name is required")`
	`305`	`+ }`
`307`	`306`	`if r.To == "" {`
`308`	`307`	`return fmt.Errorf("to address is required")`
`309`	`308`	`}`