fix circuit breaker error

Author: pierre-b

internal/service/broadcast/errors.go

@@ -41,10 +41,17 @@ type BroadcastError struct {
 
 // Error implements the error interface
 func (e *BroadcastError) Error() string {
+	if e.Err != nil {
+		if e.TaskID != "" {
+			return fmt.Sprintf("[%s] %s (task: %s): %v", e.Code, e.Message, e.TaskID, e.Err)
+		}
+		return fmt.Sprintf("[%s] %s: %v", e.Code, e.Message, e.Err)
+	}
+	// Fallback when Err is nil
 	if e.TaskID != "" {
-		return fmt.Sprintf("[%s] %s (task: %s): %v", e.Code, e.Message, e.TaskID, e.Err)
+		return fmt.Sprintf("[%s] %s (task: %s)", e.Code, e.Message, e.TaskID)
 	}
-	return fmt.Sprintf("[%s] %s: %v", e.Code, e.Message, e.Err)
+	return fmt.Sprintf("[%s] %s", e.Code, e.Message)
 }
 
 // Unwrap returns the underlying error

internal/service/broadcast/message_sender.go

@@ -210,7 +210,7 @@ func (s *messageSender) SendToRecipient(ctx context.Context, workspaceID string,
 			logFields["last_error"] = lastError.Error()
 		}
 		s.logger.WithFields(logFields).Warn("Circuit breaker open, skipping send")
-		return NewBroadcastError(ErrCodeCircuitOpen, fmt.Sprintf("circuit breaker is open: %v", lastError), true, nil)
+		return NewBroadcastError(ErrCodeCircuitOpen, "circuit breaker is open", true, lastError)
 	}
 
 	// Apply rate limiting
@@ -395,7 +395,7 @@ func (s *messageSender) SendBatch(ctx context.Context, workspaceID string, integ
 			logFields["last_error"] = lastError.Error()
 		}
 		s.logger.WithFields(logFields).Warn("Circuit breaker open, skipping batch")
-		return 0, 0, NewBroadcastError(ErrCodeCircuitOpen, fmt.Sprintf("circuit breaker is open: %v", lastError), true, nil)
+		return 0, 0, NewBroadcastError(ErrCodeCircuitOpen, "circuit breaker is open", true, lastError)
 	}
 
 	// Get the broadcast to determine variations and templates