lq 0.09-beta sound issue?

[lavenderdotpet]

@thomashope @vsonnier what was the sound is it happening just on launching the game
i haven’t run into this issue and i would like to figure out if its something we can fix on our side

[vsonnier]

Hi @lavenderdotpet, I cannot reproduce it myself on Windows 10 in MSVC Debug playing a little bit with LibreQuake, still the patch is valid memory-access wise.

Following my findings and suggestions there : sezero/quakespasm#140 (comment)

To sum up : the way we try to detect a "looping" pattern use a LIST chunk hierarchy, which (alas for us) can be anyting since it is just a container where your favorite Sound editor can put any metadata it wishes.

So, unless there is a magical option to generate a WAV "bare" there is nothing you can do... The fault is with QSs and descendants which use a very inadequate way to detect "looping", so hardening our code is the real solution.

[sezero]

The fault is with QSs and descendants which use a very inadequate way to detect "looping"

No, it is not: The loop code comes from original quake source and, as I recall, relies on a cooledit-specific feature.

[vsonnier]

No, it is not: The loop code comes from original quake source and, as I recall, relies on a cooledit-specific feature.

Right :) It seems simpler that the modern smpl chunk to manage at least. I wonder if that LIST + mark are often found, or used in Quake ?

Maybe we could log that with a Con_DPrintf for developper only, including the too-short LIST detection.

[thomashope]

Some more info if it helps. The filename in librequake is doors/doormv1.wav. On the crashing LIST chunk, iff_chunk_len is 4.

The crash occurred immediately on launching the game before reaching the menu. I'm using Xcode on an M2 Mac.

I don't have my PC with me atm, but if you have recent-ish MSVC maybe you can verify with AddressSanitizer?

[Novum]

Usually https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/application-verifier also works very well to spot memory corruption

[vsonnier]

Usually https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/application-verifier also works very well to spot memory corruption

Noted, thanks I never knew such thing existed.

@thomashope By luck I stumbled on a discrussion on Discord about looping sounds, which point to this tutorial : https://www.youtube.com/watch?v=pj7C_igr0bs by dumptruck_ds

At 07:00 the author uses that particular software OceanAudio to place "cue markers" to make the Quake sound loop, and that is exactly what I was describing above. Indeed WAV parsing lookup to 'cue ', then 'LIST', then 'mark' FOURCC codes which should correspond to what dumptruck_ds is doing.

The OOB patch is correct though and should stay, in case a 'LIST' appears below a 'cue ' without a proper 'mark' at the right place.