Skip to content

Commit 6988895

Browse files
satish-a0mwaiyeecsafreenCopilotalicia-koh
authored
Patch v0.7.1 (#181)
* Add wget no proxy flag * Remove dependency * add duckdb extensions for offline * Remove DOCKER_TREX_TAG_NAME env * Streamline env DOCKER_TAG_NAME * Revert * Use auto generated password for demodb * Create new folder to store csvs used for data loading into d2e dataset * Remove commented code * Use default password * Update scripts/load-demodatabase.mjs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Afreen <reachafreen@hotmail.com> * Add headers for omop cdm v5.3 * Skip drop column on error --------- Signed-off-by: Afreen <reachafreen@hotmail.com> Co-authored-by: mwaiyee <waiyee.man@data4life-asia.care> Co-authored-by: Afreen Sikandara <afreen.sikandara@data4life-asia.care> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: alicia-koh <alicia.koh@data4life-asia.care>
1 parent 59d6533 commit 6988895

49 files changed

Lines changed: 94 additions & 36 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

docker-compose.yml

Lines changed: 26 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ services:
110110
alp-minio-post-init:
111111
condition: service_completed_successfully
112112
hostname: ${PROJECT_NAME:-d2e}-trex.${TLS__INTERNAL__DOMAIN:-alp.local}
113-
image: ${DOCKER_IMAGE_PREFIX:-ghcr.io/ohdsi/}d2e-trex:${DOCKER_TREX_TAG_NAME:-develop}
113+
image: ${DOCKER_IMAGE_PREFIX:-ghcr.io/ohdsi/}d2e-trex:${DOCKER_TAG_NAME:-develop}
114114
pull_policy: ${TREX_PULL_POLICY:-missing}
115115
platform: linux/amd64
116116
logging:
@@ -143,7 +143,7 @@ services:
143143
- *x-minio
144144
- *x-pg
145145
- *x-perseus
146-
REP_PG: postgres://postgres:mypass@demodb:5432/postgres
146+
REP_PG: postgres://postgres:${DEMO__DB_PASSWORD}@demodb:5432/postgres
147147
SERVICE_ENV: |-
148148
{
149149
"_shared": {
@@ -490,6 +490,7 @@ services:
490490
PLUGINS_IMAGE_TAG: ${PLUGINS_IMAGE_TAG:-develop}
491491
PLUGINS_FLOW_CUSTOM_REPO_IMAGE_CONFIG: '${PLUGINS_FLOW_CUSTOM_REPO_IMAGE_CONFIG:-{}}' #{"current": "ghcr.io/ohdsi/d2e", "new": ""}
492492
PROJECT_NAME: ${PROJECT_NAME:-d2e}
493+
DEMO__DB_PASSWORD: ${DEMO__DB_PASSWORD}
493494

494495
alp-minerva-pg-mgmt-init:
495496
container_name: &c15 ${PROJECT_NAME:-d2e}-minerva-pg-mgmt-init-1
@@ -770,8 +771,6 @@ services:
770771
depends_on:
771772
alp-minio-post-init:
772773
condition: service_completed_successfully
773-
trex:
774-
condition: service_healthy
775774
alp-logto-post-init:
776775
condition: service_completed_successfully
777776
alp-dataflow-gen:
@@ -860,6 +859,8 @@ services:
860859
test:
861860
- CMD
862861
- wget
862+
- --proxy
863+
- off
863864
- -O
864865
- logto.status
865866
- http://localhost:3001/api/status
@@ -1048,12 +1049,26 @@ services:
10481049
image: ohdsi/broadsea-atlasdb:2.2.0
10491050
container_name: ${PROJECT_NAME:-d2e}-demodb
10501051
mem_limit: "2G"
1051-
command:
1052-
- "postgres"
1053-
- "-c"
1054-
- "wal_level=logical"
1052+
command: >
1053+
sh -c '
1054+
set -e;
1055+
echo "Starting PostgreSQL in background via original docker-entrypoint.sh...";
1056+
/usr/local/bin/docker-entrypoint.sh postgres -c wal_level=logical &
1057+
PG_PID=$!;
1058+
echo "Waiting for PostgreSQL to become ready...";
1059+
until pg_isready -q -U postgres -h localhost -p 5432; do
1060+
echo "PostgreSQL is unavailable - sleeping for 1 second...";
1061+
sleep 1;
1062+
done;
1063+
echo "PostgreSQL is ready on localhost:5432.";
1064+
echo "Attempting to change password for user postgres...";
1065+
psql -v ON_ERROR_STOP=1 -h localhost -U postgres -d postgres -c "ALTER USER postgres WITH PASSWORD '\''${DEMO__DB_PASSWORD}'\'';";
1066+
echo "PostgreSQL setup complete. Bringing PostgreSQL process (PID $PG_PID) to foreground...";
1067+
wait $PG_PID;
1068+
echo "PostgreSQL process (PID $PG_PID) has exited.";
1069+
exit $?;'
10551070
environment:
1056-
- POSTGRES_PASSWORD=mypass
1071+
POSTGRES_PASSWORD: ${DEMO__DB_PASSWORD}
10571072
networks:
10581073
alp:
10591074
priority: 20
@@ -1067,6 +1082,7 @@ services:
10671082
interval: 5s
10681083
timeout: 5s
10691084
retries: 10
1085+
restart: ${DOCKER__RESTART_POLICY:-unless-stopped}
10701086
profiles: [demodb]
10711087

10721088
redis:
@@ -1103,6 +1119,7 @@ services:
11031119
test:
11041120
- CMD
11051121
- wget
1122+
- --no-proxy
11061123
- -O
11071124
- fhir.status
11081125
- http://localhost:8103/healthcheck

flows/base/Dockerfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,10 @@ RUN chown -R docker:docker /app/synpuf1k
144144
RUN mkdir -p /app/vocab
145145
RUN chown -R docker:docker /app/vocab
146146

147+
# Create folder to store data load CSVs
148+
RUN mkdir -p /app/data_load
149+
RUN chown -R docker:docker /app/data_load
150+
147151
# Create folder to store duckdb extensions for offline plugins
148152
# version must match duckdb in requirements.txt
149153
ENV duckdb_version 1.2.1

flows/base/data_load_plugin/flow.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,12 @@ def format_vocab_synpuf_data(dbdao, data: pd.DataFrame, table_name: str, logger)
112112
t = ibis.memtable(data, name=table_name)
113113

114114
if table_name in columns_to_drop.keys():
115-
t = t.drop(columns_to_drop.get(table_name))
115+
for col in columns_to_drop.get(table_name):
116+
try:
117+
t = t.drop(col)
118+
except Exception as e:
119+
logger.error(f"Skipping dropping of column '{col}' from table '{table_name}' with error: {e}")
120+
continue
116121

117122
# rename columns to lower case
118123
renamed = t.rename({col.lower(): col for col in t.columns})

internal/docs/data-load/headers-synpuf1k/002_LOCATION.csv

Lines changed: 0 additions & 1 deletion
This file was deleted.

internal/docs/data-load/headers-synpuf1k/008_CONDITION_OCCURRENCE.csv

Lines changed: 0 additions & 1 deletion
This file was deleted.

internal/docs/data-load/headers-synpuf1k/014_OBSERVATION.csv

Lines changed: 0 additions & 1 deletion
This file was deleted.

internal/docs/data-load/headers-synpuf1k/017_PROCEDURE_OCCURRENCE.csv

Lines changed: 0 additions & 1 deletion
This file was deleted.

internal/docs/data-load/headers-synpuf1k/README.md

Lines changed: 0 additions & 3 deletions
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
LOCATION_ID,ADDRESS_1,ADDRESS_2,CITY,STATE,ZIP,COUNTY,LOCATION_SOURCE_VALUE

internal/docs/data-load/headers-synpuf1k/003_CARE_SITE.csv renamed to internal/docs/data-load/headers-synpuf1k/v5.3/003_CARE_SITE.csv

File renamed without changes.

0 commit comments

Comments
 (0)