Use pypinyin as a fallback for g2pw#205
Open
WhyNotHugo wants to merge 1 commit into
Open
Conversation
g2pw transitively depends on pytorch, which is not available on all target environments where piper currently runs. Use pypinyin as a fallback when g2pw is not available. Include a warning about this, since pypinyin might not be the preferred choice. My handling of Chinese is very basic, but I asked a native speaker to compare the results of both, and they claim the it sounds the same, including intonation.
WhyNotHugo
force-pushed
the
pypinyin-fallback
branch
from
April 7, 2026 22:40
039c332 to
bafdfb7
Compare
Author
|
v2: use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
g2pw transitively depends on pytorch, which is not available on all target environments where piper currently runs.
Use pypinyin as a fallback when g2pw is not available. Include a warning about this, since pypinyin might not be the preferred choice.
My handling of Chinese is very basic, but I asked a native speaker to compare the results of both, and they claim the it sounds the same, including intonation.