util: remove memrchr

And replace its only usage by strrchr as we are using a
null-terminated string in this case

Author: catenacyber

configure.ac

@@ -207,7 +207,7 @@
     AC_FUNC_MMAP
     AC_FUNC_STRTOD
 
-    AC_CHECK_FUNCS([memmem memset memchr memrchr memmove])
+    AC_CHECK_FUNCS([memmem memset memchr memmove])
     AC_CHECK_FUNCS([strcasecmp strchr strrchr strdup strndup strncasecmp strtol strstr strpbrk strtoull strtoumax])
     AC_CHECK_FUNCS([strerror])
     AC_CHECK_FUNCS([gethostname inet_ntoa uname])

src/Makefile.am

@@ -541,7 +541,6 @@ noinst_HEADERS = \
 	util-mem.h \
 	util-memcmp.h \
 	util-memcpy.h \
-	util-memrchr.h \
 	util-misc.h \
 	util-mpm-ac-ks.h \
 	util-mpm-ac-queue.h \
@@ -1100,7 +1099,6 @@ libsuricata_c_a_SOURCES = \
 	util-magic.c \
 	util-mem.c \
 	util-memcmp.c \
-	util-memrchr.c \
 	util-misc.c \
 	util-mpm-ac-ks-small.c \
 	util-mpm-ac-ks.c \

src/app-layer-htp-xff.c

@@ -29,10 +29,6 @@
 #include "app-layer-htp.h"
 #include "app-layer-htp-xff.h"
 
-#ifndef HAVE_MEMRCHR
-#include "util-memrchr.h"
-#endif
-
 #include "util-misc.h"
 #include "util-unittest.h"
 
@@ -123,7 +119,7 @@ static int HttpXFFGetIPFromTxAux(
 
         if (xff_cfg->flags & XFF_REVERSE) {
             /** Get the last IP address from the chain */
-            p_xff = memrchr(xff_chain, ' ', htp_header_value_len(h_xff));
+            p_xff = strrchr(xff_chain, ' ');
             if (p_xff == NULL) {
                 p_xff = xff_chain;
             } else {

src/runmode-unittests.c

@@ -91,7 +91,6 @@
 #include "util-proto-name.h"
 #include "util-macset.h"
 #include "util-flow-rate.h"
-#include "util-memrchr.h"
 
 #include "util-mpm-ac.h"
 #include "util-mpm-hs.h"