fix(open-xchange): stop keycloak-sync from reverting mail identity on every run

The change SOAP call (runs every 15 min, for existing accounts) was
unconditionally resetting primaryEmail/email1 back to Keycloak's
email on every sync - silently undoing any account customized to use
a different mail identity than the Keycloak login domain (hit this in
production: kept reverting kubeaid.io swaps back to obmondo.com every
15 minutes, had to suspend the CronJob entirely to stop it).

change now only touches name fields (given_name/sur_name/display_name)
- its actual job, keeping display names in sync. create (for genuinely
new accounts) still sets primaryEmail/email1 once, unaffected.

Signed-off-by: Rishi <rishi@obmondo.com>

Author: MAVRICK-1

argocd-helm-charts/open-xchange/templates/keycloak-sync-cronjob.yaml

@@ -218,6 +218,10 @@ data:
 
       # Runs unconditionally (not just on create failure) so an existing
       # user's name gets refreshed if it changed in Keycloak since last sync.
+      # Deliberately does NOT touch primaryEmail/email1 - an account's mail
+      # identity can be customized to differ from the Keycloak login domain
+      # (e.g. a test domain), and this sync must not fight that on every run.
+      # create (above) still sets them once, for genuinely new accounts only.
       curl -s -X POST "$OX_SOAP_URL" -H "Content-Type: text/xml" --data-binary @- <<SOAPEOF > /tmp/change_response.xml 2>&1
     <?xml version="1.0" encoding="UTF-8"?>
     <soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:soap="http://soap.admin.openexchange.com">
@@ -229,8 +233,6 @@ data:
             <given_name>${FIRSTNAME_X}</given_name>
             <sur_name>${LASTNAME_X}</sur_name>
             <display_name>${DISPLAYNAME_X}</display_name>
-            <primaryEmail>${EMAIL_X}</primaryEmail>
-            <email1>${EMAIL_X}</email1>
           </usrdata>
           <auth>
             <login>${OX_ADMIN}</login>