Skip to content

Commit 9ead8eb

Browse files
committed
fix(buzz): stop shipping ingress defaults that cannot be removed
Helm merges annotation maps, so the NGINX proxy timeouts and the nginx class this chart defaulted to followed every consumer downstream. A Traefik cluster setting its own annotations still got the nginx ones rendered onto the Ingress alongside them, with no way to drop them from a values file. Class and annotations are now empty and belong to the cluster. The README carries the NGINX timeouts, which matter because the relay's connections are long-lived WebSockets, and notes Traefik needs nothing extra.
1 parent b6ff1db commit 9ead8eb

2 files changed

Lines changed: 25 additions & 6 deletions

File tree

argocd-helm-charts/buzz/README.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,26 @@ tracks a newer chart version.
8686

8787
The bucket must not be folded into `buzz.s3.endpoint`; the two are passed separately.
8888

89+
## Ingress
90+
91+
`buzz.ingress.className` and `buzz.ingress.annotations` are deliberately empty. Helm merges annotation
92+
maps, so a default here would appear on every install and could not be removed downstream — set both
93+
per cluster.
94+
95+
Relay traffic is long-lived WebSockets. On NGINX raise the timeouts, or connections drop after the
96+
60s default:
97+
98+
```yaml
99+
buzz:
100+
ingress:
101+
className: nginx
102+
annotations:
103+
nginx.ingress.kubernetes.io/proxy-read-timeout: "3600"
104+
nginx.ingress.kubernetes.io/proxy-send-timeout: "3600"
105+
```
106+
107+
Traefik proxies WebSockets without extra configuration.
108+
89109
## Relay membership
90110
91111
`buzz.relay.requireRelayMembership` is `false` here, which runs an open relay and needs no operator

argocd-helm-charts/buzz/values.yaml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,13 @@ buzz:
8282
size: 10Gi
8383
# storageClass: ""
8484

85+
# Class and annotations are left to the cluster: Helm merges annotation maps,
86+
# so anything set here leaks into every install and cannot be removed
87+
# downstream. See README.md for the NGINX WebSocket timeouts.
8588
ingress:
8689
enabled: true
87-
className: nginx
88-
annotations:
89-
cert-manager.io/cluster-issuer: letsencrypt
90-
# Relay connections are long-lived WebSockets; the 60s default cuts them.
91-
nginx.ingress.kubernetes.io/proxy-read-timeout: "3600"
92-
nginx.ingress.kubernetes.io/proxy-send-timeout: "3600"
90+
className: ""
91+
annotations: {}
9392
tls:
9493
- hosts:
9594
- buzz.example.com

0 commit comments

Comments
 (0)