Skip to content

Commit 897bd81

Browse files
committed
fix: addressed review feedback
1 parent 08ba7b1 commit 897bd81

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/tracker/ui/creatures/Creature.svelte

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script lang="ts">
2-
import { DEFAULT_UNDEFINED, FRIENDLY, HIDDEN } from "src/utils";
2+
import { DEFAULT_UNDEFINED, FRIENDLY, HIDDEN, INITIATIVE_TRACKER_VIEW } from "src/utils";
33
import type { Creature } from "src/utils/creature";
44
import Initiative from "./Initiative.svelte";
55
import CreatureControls from "./CreatureControls.svelte";
@@ -23,6 +23,7 @@
2323
setIcon(div, FRIENDLY);
2424
};
2525
26+
const hoverParent: { hoverPopover: null } = { hoverPopover: null };
2627
let hoverTimeout: NodeJS.Timeout = null;
2728
const tryHover = (evt: MouseEvent) => {
2829
hoverTimeout = setTimeout(() => {
@@ -36,10 +37,11 @@
3637
[, link] = link.match(/\[\[(.+?)(?:\|.+?)?\]\]/);
3738
}
3839
40+
// @ts-expect-error — hover-link is not in Obsidian's public types
3941
app.workspace.trigger("hover-link", {
4042
event: evt,
41-
source: "initiative-tracker",
42-
hoverParent: { hoverPopover: null },
43+
source: INITIATIVE_TRACKER_VIEW,
44+
hoverParent,
4345
targetEl: evt.target as HTMLElement,
4446
linktext: link
4547
});

src/tracker/view.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ export class CreatureView extends ItemView {
101101
(ev) =>
102102
app.workspace.trigger("hover-link", {
103103
event: ev,
104-
source: "initiative-tracker",
104+
source: INITIATIVE_TRACKER_VIEW,
105105
hoverParent: this,
106106
targetEl: ev.target as HTMLElement,
107107
linktext:

0 commit comments

Comments
 (0)