Issue #156: Correcting boolean logic for determining write authorizations for a given document

Author: Dave Kichler

etc/sync-function-authorization-module.js

@@ -57,9 +57,11 @@ function() {
       appendToAuthorizationList(requiredAuthorizations, authorizationMap.write);
     }
 
-    if (doc._deleted && authorizationMap.remove) {
-      writeAuthorizationFound = true;
-      appendToAuthorizationList(requiredAuthorizations, authorizationMap.remove);
+    if (doc._deleted) {
+      if (authorizationMap.remove) {
+        writeAuthorizationFound = true;
+        appendToAuthorizationList(requiredAuthorizations, authorizationMap.remove);
+      }
     } else if (!isDocumentMissingOrDeleted(oldDoc) && authorizationMap.replace) {
       writeAuthorizationFound = true;
       appendToAuthorizationList(requiredAuthorizations, authorizationMap.replace);

etc/test-helper.js

@@ -645,11 +645,11 @@ function verifyAccessDenied(doc, oldDoc, expectedAuthorization) {
     } else if (countAuthorizationTypes(expectedAuthorization) > 1) {
       assert.equal(ex.forbidden, generalAuthFailedMessage, 'Expected authorization exception not met: ' + ex.forbidden);
     } else if (expectedAuthorization.expectedChannels) {
-      assert.ok(ex instanceof Error && ex.message === channelAccessDenied.message, 'Expected channel authorization error not triggered, got this instead: ' + ex);
+      assert.equal(ex, channelAccessDenied, 'Expected channel authorization error not triggered, got this instead: ' + ex);
     } else if (expectedAuthorization.expectedRoles) {
-      assert.ok(ex instanceof Error && ex.message === roleAccessDenied.message, 'Expected role authorization error not triggered, got this instead: ' + ex);
+      assert.equal(ex, roleAccessDenied, 'Expected role authorization error not triggered, got this instead: ' + ex);
     } else if (expectedAuthorization.expectedUsers) {
-      assert.ok(ex instanceof Error && ex.message === userAccessDenied.message, 'Expected user authorization error not triggered, got this instead: ' + ex);
+      assert.equal(ex, userAccessDenied, 'Expected user authorization error not triggered, got this instead: ' + ex);
     }
   }
 

test/authorization-spec.js

@@ -266,7 +266,7 @@ describe('Authorization:', function() {
         stringProp: 'foobar'
       };
 
-      testHelper.verifyAccessDenied(doc, oldDoc, { expectedRoles: [ ] });
+      testHelper.verifyAccessDenied(doc, oldDoc, []);
     });
   });