Merge pull request #1527 from amanjn38/fix/npe-getAllSituations

Add null guards in UIUtils.getAllSituations() to prevent NPE

Author: aaronbrethorst

onebusaway-android/src/main/java/org/onebusaway/android/ui/ArrivalsListFragment.java

@@ -971,7 +971,9 @@ public ArrayList<String> getRoutesFilter() {
     public void setRoutesFilter(ArrayList<String> routes) {
         mRoutesFilter = routes;
         ObaContract.StopRouteFilters.set(getActivity(), mStopId, mRoutesFilter);
-        refreshSituations(UIUtils.getAllSituations(getArrivalsLoader().getLastGoodResponse(), mRoutesFilter));
+        ArrivalsListLoader loader = getArrivalsLoader();
+        ObaArrivalInfoResponse lastGood = loader != null ? loader.getLastGoodResponse() : null;
+        refreshSituations(UIUtils.getAllSituations(lastGood, mRoutesFilter));
         refreshLocal();
     }
 

onebusaway-android/src/main/java/org/onebusaway/android/util/UIUtils.java

@@ -1557,6 +1557,11 @@ public static void closeKeyboard(Context context, View v) {
      */
     public static List<ObaSituation> getAllSituations(final ObaArrivalInfoResponse response, List<String> filter) {
         List<ObaSituation> allSituations = new ArrayList<>();
+
+        if (response == null) {
+            return allSituations;
+        }
+
         // Add agency-wide and stop-specific alerts
         allSituations.addAll(response.getSituations());
 
@@ -1578,9 +1583,16 @@ public static List<ObaSituation> getAllSituations(final ObaArrivalInfoResponse r
         // If a filter list exists and a route_id is not included in the filter list, don't included
         // it's situations in the returned list.
         ObaArrivalInfo[] info = response.getArrivalInfo();
+        if (info == null) {
+            return allSituations;
+        }
         for (ObaArrivalInfo i : info) {
+            String[] situationIds = i.getSituationIds();
+            if (situationIds == null) {
+                continue;
+            }
             if (filterIds.isEmpty() || filterIds.contains(i.getRouteId())) {
-                for (String situationId : i.getSituationIds()) {
+                for (String situationId : situationIds) {
                     if (!allIds.contains(situationId)) {
                         allIds.add(situationId);
                         allSituations.add(response.getSituation(situationId));