@amrhossamdev I would like to work on this issue, here is my technical approach for it:

1)how the data will be stored

Database Schema

Extend the Room database (AppDatabase.kt)so that it includes a new entity for saved trips:

Create SavedTripEntity.kt:

@Entity(tableName = "saved_trips")
data class SavedTripEntity(
    @PrimaryKey(autoGenerate = true) val id: Long = 0,
    val name: String,
    val fromAddress: String,
    val fromLat: Double,
    val fromLon: Double,
    val toAddress: String,
    val toLat: Double,
    val toLon: Double,
    val arriveBy: Boolean,
    val dateTime: Long?,
    val optimizeType: String,
    val wheelchairAccessible: Boolean,
    val maxWalkDistance: Double?,
    val modeSet: String?,
    val regionId: Int,
    val timestamp: Long,
    val useCount: Int = 0
)

Fields rationale:

name: decided by user for the trip
fromAddress/fromLat/fromLon: Origin location (maps to CustomAddress from TripRequestBuilder)
toAddress/toLat/toLon: Destination location
arriveBy: Whether this is arrival or departure time constraint
dateTime: Saved date/time preference (nullable - can use "now" on reuse)
optimizeType: Transfer optimization preference
wheelchairAccessible: Accessibility requirement
maxWalkDistance: Maximum walking distance
modeSet: Travel modes (transit, bus, rail, bikeshare)
regionId: Foreign key to regions table
timestamp: When the trip was saved
useCount: Track usage frequency (for sorting)

DAO Interface

Create SavedTripDao.kt:

@Dao
interface SavedTripDao {
    @Insert
    suspend fun insertTrip(trip: SavedTripEntity): Long
    
    @Query("SELECT * FROM saved_trips WHERE regionId = :regionId ORDER BY timestamp DESC")
    suspend fun getAllTrips(regionId: Int): List<SavedTripEntity>
    
    @Query("SELECT * FROM saved_trips WHERE id = :id")
    suspend fun getTripById(id: Long): SavedTripEntity?
    
    @Query("DELETE FROM saved_trips WHERE id = :id")
    suspend fun deleteTrip(id: Long)
    
    @Query("DELETE FROM saved_trips")
    suspend fun deleteAllTrips()
    
    @Query("UPDATE saved_trips SET useCount = useCount + 1 WHERE id = :id")
    suspend fun incrementUseCount(id: Long)
    
    @Query("SELECT * FROM saved_trips WHERE regionId = :regionId ORDER BY useCount DESC")
    suspend fun getTripsByFrequency(regionId: Int): List<SavedTripEntity>
}

Database Update

Update AppDatabase.kt:

Add SavedTripEntity::class to entities array
Increment database version to 3
Add abstract fun savedTripDao(): SavedTripDao
Create migration from version 2 to 3

2) Ui

A. Save Trip Button in Results Screen

Modify fragment_trip_plan_results.xml:
I'll add a save button in the results header area (above the route options):

<ImageButton
    android:id="@+id/save_trip_button"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:src="@drawable/ic_save"
    android:contentDescription="@string/trip_save_button"
    android:background="?attr/selectableItemBackground" />

Modify TripResultsFragment.java:

Add member variable ImageButton mSaveTripButton
Initialize button in onCreateView()
Add click listener to show name input dialog

B. Name Trip Dialog

Create a dialog when user clicks save:

Use AlertDialog.Builder with an EditText input (pattern similar to ArrivalsListHeader.java line 456-465 for naming stops)
Default name: "Trip from [origin] to [destination]"
Save button triggers the save operation

C. Saved Trips List Screen

Create MySavedTripsFragment.java:

Extend a new base class MyTripListFragmentBase (similar to MyStopListFragmentBase.java)
Use RecyclerView with a custom adapter (Room database doesn't use CursorLoader)
Display: trip name, origin → destination, last used date
Long-press context menu: Delete, Share, Edit Name
Options menu: Clear All, Sort By (name, date saved, frequently used)

Create layout fragment_my_saved_trips.xml:

RecyclerView for trip list
Empty state view

Create list item layout saved_trip_list_item.xml:

- Trip name (TextView, bold)
- Origin → Destination (TextView, smaller)
- Last used/saved date (TextView, small, gray)
- Share icon (ImageButton)

D. Navigation to Saved Trips

Option 1: Add to MyStopsActivity tabs

Modify MyStopsActivity.java to add a fourth tab:

Tab name: "Saved Trips"
Icon: ic_tab_saved_trips (create new icon)
TabListener for MySavedTripsFragment

Option 2: Add to main navigation

Add menu item in HomeActivity navigation drawer or overflow menu:

Menu item: "My Saved Trips"
Intent to launch MySavedTripsActivity

Recommendation: Option 2 is cleaner since trips are different from stops

Create MySavedTripsActivity.java:

Simple activity hosting MySavedTripsFragment
Similar structure to MyStopsActivity.java

3. Core Logic

Trip Conversion Helper

Create SavedTripConverter.java:

public class SavedTripConverter {
    // Convert TripRequestBuilder to SavedTripEntity
    public static SavedTripEntity toEntity(String name, TripRequestBuilder builder, int regionId);
    
    // Convert SavedTripEntity back to TripRequestBuilder
    public static TripRequestBuilder fromEntity(SavedTripEntity entity);
    
    // Generate default trip name
    public static String generateDefaultName(CustomAddress from, CustomAddress to);
    
    // Format trip for sharing
    public static String formatTripForSharing(SavedTripEntity entity, Context context);
}

Implementation details:

Use copyIntoBundleSimple() pattern from TripRequestBuilder.java (line 352-370)
Store CustomAddress fields as individual primitives in entity
Use initFromBundleSimple() pattern for reconstruction (line 375-403)

Manager Class

Create SavedTripsManager.java:

public class SavedTripsManager {
    private final Context context;
    private final SavedTripDao dao;
    
    // Save a trip plan with name
    public void saveTrip(String name, TripRequestBuilder builder, Callback callback);
    
    // Get all saved trips
    public void getAllTrips(TripsCallback callback);
    
    // Delete a trip
    public void deleteTrip(long tripId, Callback callback);
    
    // Delete all trips
    public void deleteAllTrips(Callback callback);
    
    // Increment use count when trip is reused
    public void markTripAsUsed(long tripId);
    
    // Get trips sorted by frequency
    public void getTripsByFrequency(TripsCallback callback);
    
    interface Callback { void onComplete(boolean success); }
    interface TripsCallback { void onTripsLoaded(List<SavedTripEntity> trips); }
}

4. Integration Points

A. Save Action from Results Screen

In TripResultsFragment.java:

private void showSaveTripDialog() {
    // Get TripRequestBuilder from parent activity
    TripPlanActivity activity = (TripPlanActivity) getActivity();
    TripRequestBuilder builder = activity.mBuilder;
    
    // Show dialog with default name
    String defaultName = SavedTripConverter.generateDefaultName(
        builder.getFrom(), builder.getTo());
    
    AlertDialog dialog = // create dialog with EditText
    // On positive button: call SavedTripsManager.saveTrip()
}

B. Clicking on Saved Trip

In MySavedTripsFragment.java:

@Override
public void onTripItemClick(SavedTripEntity trip) {
    // Convert entity to builder
    TripRequestBuilder builder = SavedTripConverter.fromEntity(trip);
    
    // Update timestamp to "now" (unless user wants exact same time)
    builder.setDateTime(new Date());
    
    // Launch TripPlanActivity with builder bundle
    Intent intent = new Intent(getContext(), TripPlanActivity.class);
    intent.putExtras(builder.getBundle());
    startActivity(intent);
    
    // Mark trip as used
    SavedTripsManager.markTripAsUsed(trip.id);
}

C. Share Action

In MySavedTripsFragment.java or list item click:

private void shareTripPlan(SavedTripEntity trip) {
    String shareText = SavedTripConverter.formatTripForSharing(trip, getContext());
    
    Intent shareIntent = new Intent(Intent.ACTION_SEND);
    shareIntent.setType("text/plain");
    shareIntent.putExtra(Intent.EXTRA_SUBJECT, 
        getString(R.string.trip_share_subject, trip.name));
    shareIntent.putExtra(Intent.EXTRA_TEXT, shareText);
    
    startActivity(Intent.createChooser(shareIntent, 
        getString(R.string.trip_share_chooser_title)));
}

Share text format:

My Trip: [Trip Name]
From: [Origin Address]
To: [Destination Address]
Preferences: [Depart/Arrive by], [Mode(s)]
Planned via OneBusAway

5. Implementation Files Summary

New Files to Create:

SavedTripEntity.kt - Room entity
SavedTripDao.kt - DAO interface
SavedTripConverter.java - Conversion utilities
SavedTripsManager.java - Business logic manager
MySavedTripsFragment.java - List fragment
MySavedTripsActivity.java - Host activity
SavedTripsAdapter.java - RecyclerView adapter
fragment_my_saved_trips.xml - Fragment layout
saved_trip_list_item.xml - List item layout
activity_my_saved_trips.xml - Activity layout

Files to Modify:

AppDatabase.kt - Add entity and DAO, increment version
TripResultsFragment.java - Add save button and handler
fragment_trip_plan_results.xml - Add save button UI
HomeActivity.java or main menu - Add navigation to saved trips
strings.xml - Add all UI strings
AndroidManifest.xml - Register new activity

6. Testing Considerations

Test saving trips across different regions
Test with various CustomAddress formats (lat/lon vs. text addresses)
Test reusing trips with "now" vs. saved time
Test sharing via different apps
Test database migration from v2 to v3
Test empty states and error handling

plz correct me if I missed something

Save, Reuse, and Share Planned Trips #1110

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions