fix(android): fix copy-paste bug in LocationStateHolderTest, improve ServiceEventBusTest

Author: Vedd-Patel

android/app/src/test/java/org/onebusaway/vehiclepositions/util/LocationStateHolderTest.kt

@@ -1,11 +1,22 @@
 package org.onebusaway.vehiclepositions.util
 
+import android.location.Location
+import org.junit.Assert.assertFalse
 import org.junit.Assert.assertNull
+import org.junit.Assert.assertTrue
+import org.junit.Before
 import org.junit.Test
+import org.mockito.Mockito.mock
+import org.mockito.Mockito.`when`
 
 class LocationStateHolderTest {
 
-    private val holder = LocationStateHolder()
+    private lateinit var holder: LocationStateHolder
+
+    @Before
+    fun setup() {
+        holder = LocationStateHolder()
+    }
 
     @Test
     fun `initial location is null`() {
@@ -14,6 +25,26 @@ class LocationStateHolderTest {
 
     @Test
     fun `hasLocation returns false when no location set`() {
-        assertNull(holder.lastLocation.value)
+        assertFalse(holder.hasLocation())
+    }
+
+    @Test
+    fun `hasLocation returns true after location updated`() {
+        val mockLocation = mock(Location::class.java)
+
+        holder.updateLocation(mockLocation)
+        assertTrue(holder.hasLocation())
+    }
+
+    @Test
+    fun `lastLocation value updated after updateLocation`() {
+        val mockLocation = mock(Location::class.java)
+        `when`(mockLocation.latitude).thenReturn(1.2921)
+        `when`(mockLocation.longitude).thenReturn(36.8219)
+
+        holder.updateLocation(mockLocation)
+
+        assertTrue(holder.lastLocation.value?.latitude == 1.2921)
+        assertTrue(holder.lastLocation.value?.longitude == 36.8219)
     }
 }

android/app/src/test/java/org/onebusaway/vehiclepositions/util/ServiceEventBusTest.kt

@@ -1,13 +1,83 @@
 package org.onebusaway.vehiclepositions.util
 
+import kotlinx.coroutines.flow.toList
+import kotlinx.coroutines.launch
+import kotlinx.coroutines.test.UnconfinedTestDispatcher
+import kotlinx.coroutines.test.runTest
+import org.junit.Assert.assertEquals
 import org.junit.Assert.assertNotNull
+import org.junit.Before
 import org.junit.Test
 
 class ServiceEventBusTest {
 
+    private lateinit var bus: ServiceEventBus
+
+    @Before
+    fun setup() {
+        bus = ServiceEventBus()
+    }
+
     @Test
     fun `ServiceEventBus initializes without error`() {
-        val bus = ServiceEventBus()
         assertNotNull(bus)
     }
+
+    @Test
+    fun `emitting StopShift event is received by collector`() = runTest {
+        val events = mutableListOf<ServiceEvent>()
+
+        // starts listening in the background before emitting
+        backgroundScope.launch(UnconfinedTestDispatcher(testScheduler)) {
+            bus.events.toList(events)
+        }
+
+        bus.emitStopShift()
+
+        assertEquals(ServiceEvent.StopShift, events.first())
+    }
+
+    @Test
+    fun `emitting NavigateToLogin event is received by collector`() = runTest {
+        val events = mutableListOf<ServiceEvent>()
+
+        backgroundScope.launch(UnconfinedTestDispatcher(testScheduler)) {
+            bus.events.toList(events)
+        }
+
+        bus.emitNavigateToLogin()
+
+        assertEquals(ServiceEvent.NavigateToLogin, events.first())
+    }
+
+    @Test
+    fun `emitting LocationPermissionRevoked event is received by collector`() = runTest {
+        val events = mutableListOf<ServiceEvent>()
+
+        backgroundScope.launch(UnconfinedTestDispatcher(testScheduler)) {
+            bus.events.toList(events)
+        }
+
+        bus.emitLocationPermissionRevoked()
+
+        assertEquals(ServiceEvent.LocationPermissionRevoked, events.first())
+    }
+
+    @Test
+    fun `multiple events are received in order`() = runTest {
+        val events = mutableListOf<ServiceEvent>()
+
+        backgroundScope.launch(UnconfinedTestDispatcher(testScheduler)) {
+            bus.events.toList(events)
+        }
+
+        bus.emitStopShift()
+        bus.emitNavigateToLogin()
+        bus.emitLocationPermissionRevoked()
+
+        assertEquals(3, events.size)
+        assertEquals(ServiceEvent.StopShift, events[0])
+        assertEquals(ServiceEvent.NavigateToLogin, events[1])
+        assertEquals(ServiceEvent.LocationPermissionRevoked, events[2])
+    }
 }