test: add concurrent, edge case, and error handling tests for trip endpoints

Author: diveshpatil9104

store_trips_test.go

@@ -2,6 +2,7 @@ package main
 
 import (
 	"context"
+	"sync"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -192,3 +193,85 @@ func TestStore_StartTrip_AfterEndingPrevious(t *testing.T) {
 	assert.NotEqual(t, trip1.ID, trip2.ID)
 	assert.Equal(t, "active", trip2.Status)
 }
+
+func TestStore_StartTrip_ConcurrentAttempts(t *testing.T) {
+	store := newTestStore(t)
+	userID := setupTripTestData(t, store)
+
+	const goroutines = 10
+	var wg sync.WaitGroup
+	wg.Add(goroutines)
+
+	successes := make(chan int64, goroutines)
+	failures := make(chan error, goroutines)
+
+	for i := 0; i < goroutines; i++ {
+		go func() {
+			defer wg.Done()
+			trip, err := store.StartTrip(context.Background(), userID, "bus-trip-1", "route-5", "")
+			if err != nil {
+				failures <- err
+				return
+			}
+			successes <- trip.ID
+		}()
+	}
+
+	wg.Wait()
+	close(successes)
+	close(failures)
+
+	// Exactly one goroutine should succeed.
+	var successCount int
+	for range successes {
+		successCount++
+	}
+	assert.Equal(t, 1, successCount, "exactly one concurrent StartTrip should succeed")
+
+	// The rest should fail with ErrActiveTripExists or ErrNotAssigned (serialization error).
+	var failCount int
+	for range failures {
+		failCount++
+	}
+	assert.Equal(t, goroutines-1, failCount)
+
+	// Verify only one trip in DB.
+	var count int
+	err := store.pool.QueryRow(context.Background(), "SELECT COUNT(*) FROM trips WHERE user_id = $1 AND status = 'active'", userID).Scan(&count)
+	require.NoError(t, err)
+	assert.Equal(t, 1, count, "only one active trip should exist after concurrent attempts")
+}
+
+func TestStore_StartTrip_EmptyOptionalFields(t *testing.T) {
+	store := newTestStore(t)
+	userID := setupTripTestData(t, store)
+	ctx := context.Background()
+
+	// route_id and gtfs_trip_id are optional — empty strings should work.
+	trip, err := store.StartTrip(ctx, userID, "bus-trip-1", "", "")
+	require.NoError(t, err)
+	assert.Equal(t, "", trip.RouteID)
+	assert.Equal(t, "", trip.GtfsTripID)
+}
+
+func TestStore_EndTrip_UpdatedAtChanges(t *testing.T) {
+	store := newTestStore(t)
+	userID := setupTripTestData(t, store)
+	ctx := context.Background()
+
+	trip, err := store.StartTrip(ctx, userID, "bus-trip-1", "route-5", "")
+	require.NoError(t, err)
+
+	// Get created_at for comparison.
+	var createdAt, updatedAt interface{}
+	err = store.pool.QueryRow(ctx, "SELECT created_at, updated_at FROM trips WHERE id = $1", trip.ID).Scan(&createdAt, &updatedAt)
+	require.NoError(t, err)
+
+	err = store.EndTrip(ctx, trip.ID, userID)
+	require.NoError(t, err)
+
+	var newUpdatedAt interface{}
+	err = store.pool.QueryRow(ctx, "SELECT updated_at FROM trips WHERE id = $1", trip.ID).Scan(&newUpdatedAt)
+	require.NoError(t, err)
+	assert.NotEqual(t, updatedAt, newUpdatedAt, "updated_at should change after ending trip")
+}

trip_handlers_test.go

@@ -199,3 +199,116 @@ func TestHandleEndTrip_MissingClaims(t *testing.T) {
 
 	assert.Equal(t, http.StatusInternalServerError, w.Code)
 }
+
+func TestHandleStartTrip_TrailingJSON(t *testing.T) {
+	store := &mockTripStarter{}
+	handler := handleStartTrip(store)
+
+	body := []byte(`{"vehicle_id":"bus-1"}{"extra":true}`)
+	req := httptest.NewRequest("POST", "/", bytes.NewReader(body))
+	req.Header.Set("Content-Type", "application/json")
+	claims := jwt.MapClaims{"sub": "42"}
+	ctx := context.WithValue(req.Context(), claimsKey, claims)
+	req = req.WithContext(ctx)
+	w := httptest.NewRecorder()
+	handler(w, req)
+
+	assert.Equal(t, http.StatusBadRequest, w.Code)
+}
+
+func TestHandleEndTrip_TrailingJSON(t *testing.T) {
+	store := &mockTripEnder{}
+	handler := handleEndTrip(store)
+
+	body := []byte(`{"trip_id":1}{"extra":true}`)
+	req := httptest.NewRequest("POST", "/", bytes.NewReader(body))
+	req.Header.Set("Content-Type", "application/json")
+	claims := jwt.MapClaims{"sub": "42"}
+	ctx := context.WithValue(req.Context(), claimsKey, claims)
+	req = req.WithContext(ctx)
+	w := httptest.NewRecorder()
+	handler(w, req)
+
+	assert.Equal(t, http.StatusBadRequest, w.Code)
+}
+
+func TestHandleStartTrip_UnknownFields(t *testing.T) {
+	store := &mockTripStarter{}
+	handler := handleStartTrip(store)
+
+	body := []byte(`{"vehicle_id":"bus-1","unknown_field":"value"}`)
+	req := httptest.NewRequest("POST", "/", bytes.NewReader(body))
+	req.Header.Set("Content-Type", "application/json")
+	claims := jwt.MapClaims{"sub": "42"}
+	ctx := context.WithValue(req.Context(), claimsKey, claims)
+	req = req.WithContext(ctx)
+	w := httptest.NewRecorder()
+	handler(w, req)
+
+	assert.Equal(t, http.StatusBadRequest, w.Code)
+}
+
+func TestHandleStartTrip_InvalidSubClaim(t *testing.T) {
+	store := &mockTripStarter{}
+	handler := handleStartTrip(store)
+
+	body, _ := json.Marshal(StartTripRequest{VehicleID: "bus-1"})
+	req := httptest.NewRequest("POST", "/", bytes.NewReader(body))
+	req.Header.Set("Content-Type", "application/json")
+	// sub is not a valid integer string
+	claims := jwt.MapClaims{"sub": "not-a-number"}
+	ctx := context.WithValue(req.Context(), claimsKey, claims)
+	req = req.WithContext(ctx)
+	w := httptest.NewRecorder()
+	handler(w, req)
+
+	assert.Equal(t, http.StatusUnauthorized, w.Code)
+}
+
+func TestHandleEndTrip_InvalidSubClaim(t *testing.T) {
+	store := &mockTripEnder{}
+	handler := handleEndTrip(store)
+
+	body, _ := json.Marshal(EndTripRequest{TripID: 1})
+	req := httptest.NewRequest("POST", "/", bytes.NewReader(body))
+	req.Header.Set("Content-Type", "application/json")
+	claims := jwt.MapClaims{"sub": "not-a-number"}
+	ctx := context.WithValue(req.Context(), claimsKey, claims)
+	req = req.WithContext(ctx)
+	w := httptest.NewRecorder()
+	handler(w, req)
+
+	assert.Equal(t, http.StatusUnauthorized, w.Code)
+}
+
+func TestHandleStartTrip_EmptySub(t *testing.T) {
+	store := &mockTripStarter{}
+	handler := handleStartTrip(store)
+
+	body, _ := json.Marshal(StartTripRequest{VehicleID: "bus-1"})
+	req := httptest.NewRequest("POST", "/", bytes.NewReader(body))
+	req.Header.Set("Content-Type", "application/json")
+	claims := jwt.MapClaims{"sub": ""}
+	ctx := context.WithValue(req.Context(), claimsKey, claims)
+	req = req.WithContext(ctx)
+	w := httptest.NewRecorder()
+	handler(w, req)
+
+	assert.Equal(t, http.StatusUnauthorized, w.Code)
+}
+
+func TestHandleStartTrip_InternalServerError(t *testing.T) {
+	store := &mockTripStarter{err: assert.AnError}
+	handler := handleStartTrip(store)
+	w := tripRequest(t, handler, "42", StartTripRequest{VehicleID: "bus-1"})
+
+	assert.Equal(t, http.StatusInternalServerError, w.Code)
+}
+
+func TestHandleEndTrip_InternalServerError(t *testing.T) {
+	store := &mockTripEnder{err: assert.AnError}
+	handler := handleEndTrip(store)
+	w := tripRequest(t, handler, "42", EndTripRequest{TripID: 1})
+
+	assert.Equal(t, http.StatusInternalServerError, w.Code)
+}