test(android): add instrumented tests for TokenManager, ShiftStateManager

Author: Vedd-Patel

android/app/build.gradle.kts

@@ -74,10 +74,15 @@ dependencies {
 
     // Tests
     testImplementation(libs.junit)
+    testImplementation(libs.kotlinx.coroutines.test)
+    testImplementation("org.mockito:mockito-core:5.7.0")
     androidTestImplementation(libs.androidx.junit)
     androidTestImplementation(libs.androidx.espresso.core)
     androidTestImplementation(platform(libs.androidx.compose.bom))
     androidTestImplementation(libs.androidx.compose.ui.test.junit4)
+    androidTestImplementation(libs.androidx.test.core)
+    androidTestImplementation(libs.androidx.test.ext.junit)
+    androidTestImplementation(libs.kotlinx.coroutines.test)
     debugImplementation(libs.androidx.compose.ui.tooling)
     debugImplementation(libs.androidx.compose.ui.test.manifest)
 

android/app/src/androidTest/java/org/onebusaway/vehiclepositions/util/ShiftStateManagerTest.kt

@@ -1,51 +1,78 @@
 package org.onebusaway.vehiclepositions.util
 
+import android.content.Context
+import androidx.datastore.preferences.core.edit
+import androidx.test.core.app.ApplicationProvider
+import androidx.test.ext.junit.runners.AndroidJUnit4
 import kotlinx.coroutines.flow.first
+import kotlinx.coroutines.runBlocking
 import kotlinx.coroutines.test.runTest
+import org.junit.After
 import org.junit.Assert.assertEquals
-import org.junit.Assert.assertNotNull
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertNull
+import org.junit.Assert.assertTrue
 import org.junit.Before
 import org.junit.Test
+import org.junit.runner.RunWith
 
-class ServiceEventBusTest {
+@RunWith(AndroidJUnit4::class)
+class ShiftStateManagerTest {
 
-    private lateinit var bus: ServiceEventBus
+    private lateinit var context: Context
+    private lateinit var manager: ShiftStateManager
 
     @Before
     fun setup() {
-        bus = ServiceEventBus()
+        context = ApplicationProvider.getApplicationContext()
+        manager = ShiftStateManager(context)
+
+        runBlocking {
+            context.dataStore.edit { preferences ->
+                preferences.clear()
+            }
+        }
+    }
+
+    @After
+    fun teardown() {
+        runBlocking {
+            context.dataStore.edit { preferences ->
+                preferences.clear()
+            }
+        }
     }
 
     @Test
-    fun `ServiceEventBus initializes without error`() {
-        assertNotNull(bus)
+    fun initialShiftStateIsNotActive() = runTest {
+        assertFalse(manager.isShiftActive.first())
     }
 
     @Test
-    fun `emitting StopShift event is received by collector`() = runTest {
-        bus.emitStopShift()
-        val event = bus.events.first()
-        assertEquals(ServiceEvent.StopShift, event)
+    fun initialVehicleIdIsNull() = runTest {
+        assertNull(manager.activeVehicleId.first())
     }
 
     @Test
-    fun `emitting NavigateToLogin event is received by collector`() = runTest {
-        bus.emitNavigateToLogin()
-        val event = bus.events.first()
-        assertEquals(ServiceEvent.NavigateToLogin, event)
+    fun startShiftSetsShiftActiveAndVehicleId() = runTest {
+        manager.startShift("2045")
+        assertTrue(manager.isShiftActive.first())
+        assertEquals("2045", manager.activeVehicleId.first())
     }
 
     @Test
-    fun `emitting LocationPermissionRevoked event is received by collector`() = runTest {
-        bus.emitLocationPermissionRevoked()
-        val event = bus.events.first()
-        assertEquals(ServiceEvent.LocationPermissionRevoked, event)
+    fun endShiftClearsShiftState() = runTest {
+        manager.startShift("2045")
+        manager.endShift()
+        assertFalse(manager.isShiftActive.first())
+        assertNull(manager.activeVehicleId.first())
     }
 
     @Test
-    fun `multiple events are received in order`() = runTest {
-        bus.emitStopShift()
-        val event = bus.events.first()
-        assertEquals(ServiceEvent.StopShift, event)
+    fun startShiftWithDifferentVehicleIdUpdatesCorrectly() = runTest {
+        manager.startShift("2045")
+        manager.endShift()
+        manager.startShift("9999")
+        assertEquals("9999", manager.activeVehicleId.first())
     }
 }

android/app/src/androidTest/java/org/onebusaway/vehiclepositions/util/TokenManagerTest.kt

@@ -1,4 +1,75 @@
 package org.onebusaway.vehiclepositions.util
 
+import android.content.Context
+import androidx.test.core.app.ApplicationProvider
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertNull
+import org.junit.Assert.assertTrue
+import org.junit.Before
+import org.junit.Test
+import org.junit.runner.RunWith
+
+@RunWith(AndroidJUnit4::class)
 class TokenManagerTest {
+
+    private lateinit var context: Context
+    private lateinit var tokenManager: TokenManager
+
+    @Before
+    fun setup() {
+        context = ApplicationProvider.getApplicationContext()
+        tokenManager = TokenManager(context)
+        tokenManager.clearTokens()
+    }
+
+    @Test
+    fun initialTokenIsNull() {
+        assertNull(tokenManager.getToken())
+    }
+
+    @Test
+    fun initialRefreshTokenIsNull() {
+        assertNull(tokenManager.getRefreshToken())
+    }
+
+    @Test
+    fun isLoggedInReturnsFalseWhenNoToken() {
+        assertFalse(tokenManager.isLoggedIn())
+    }
+
+    @Test
+    fun saveTokenStoresTokenCorrectly() {
+        tokenManager.saveToken("test_jwt_token")
+        assertEquals("test_jwt_token", tokenManager.getToken())
+    }
+
+    @Test
+    fun saveRefreshTokenStoresRefreshTokenCorrectly() {
+        tokenManager.saveRefreshToken("test_refresh_token")
+        assertEquals("test_refresh_token", tokenManager.getRefreshToken())
+    }
+
+    @Test
+    fun isLoggedInReturnsTrueAfterSaveToken() {
+        tokenManager.saveToken("test_jwt_token")
+        assertTrue(tokenManager.isLoggedIn())
+    }
+
+    @Test
+    fun clearTokensRemovesBothTokens() {
+        tokenManager.saveToken("test_jwt_token")
+        tokenManager.saveRefreshToken("test_refresh_token")
+        tokenManager.clearTokens()
+        assertNull(tokenManager.getToken())
+        assertNull(tokenManager.getRefreshToken())
+    }
+
+    @Test
+    fun isLoggedInReturnsFalseAfterClearTokens() {
+        tokenManager.saveToken("test_jwt_token")
+        tokenManager.clearTokens()
+        assertFalse(tokenManager.isLoggedIn())
+    }
 }

android/gradle/libs.versions.toml

@@ -1,6 +1,7 @@
 [versions]
 agp = "9.1.0"
 coreKtx = "1.18.0"
+coroutinesTest = "1.8.1"
 junit = "4.13.2"
 junitVersion = "1.3.0"
 espressoCore = "3.7.0"
@@ -39,6 +40,9 @@ androidx-compose-ui-tooling = { group = "androidx.compose.ui", name = "ui-toolin
 androidx-compose-ui-tooling-preview = { group = "androidx.compose.ui", name = "ui-tooling-preview" }
 androidx-compose-ui-test-manifest = { group = "androidx.compose.ui", name = "ui-test-manifest" }
 androidx-compose-ui-test-junit4 = { group = "androidx.compose.ui", name = "ui-test-junit4" }
+androidx-test-core = { group = "androidx.test", name = "core-ktx", version = "1.6.1" }
+androidx-test-ext-junit = { group = "androidx.test.ext", name = "junit-ktx", version = "1.2.1" }
+kotlinx-coroutines-test = { group = "org.jetbrains.kotlinx", name = "kotlinx-coroutines-test", version.ref = "coroutinesTest" }
 androidx-compose-material3 = { group = "androidx.compose.material3", name = "material3" }
 material = { group = "com.google.android.material", name = "material", version.ref = "material" }
 maps = { group = "com.google.android.gms", name = "play-services-maps", version.ref = "maps" }