Skip to content

fix: 脱困后无法重新检测丢失的虚空 - #2457

Merged
ShadowLemoon merged 1 commit into
OneDragon-Anything:mainfrom
kawayiYokami:fix/lost-void-redetect-unstuck
Jul 8, 2026
Merged

fix: 脱困后无法重新检测丢失的虚空#2457
ShadowLemoon merged 1 commit into
OneDragon-Anything:mainfrom
kawayiYokami:fix/lost-void-redetect-unstuck

Conversation

@kawayiYokami

@kawayiYokami kawayiYokami commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

修复了角色脱困后,丢失的虚空无法重新被检测的问题。

Summary by CodeRabbit

  • Bug Fixes
    • 优化了“脱困”后的流程切换条件,只有在特定持续状态下才会继续进入后续移动前转向流程。
    • 减少了异常状态下的误转移,使流程表现更稳定、更符合预期。

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

在 LostVoidMoveByDet 的节点转移配置中,为进入“移动前转向”节点新增了来自“脱困”节点的状态过滤条件,仅当状态为 STATUS_CONTINUE 时才允许该转移,原先无状态约束。

Changes

迷失虚境节点转移条件

Layer / File(s) Summary
脱困到移动前转向的状态过滤
src/zzz_od/application/hollow_zero/lost_void/operation/lost_void_move_by_det.py
为节点转移装饰器新增 status=STATUS_CONTINUE 条件限制,替代原先无状态约束的转移逻辑。

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了脱困后无法重新检测丢失虚空的修复方向,与本次状态过滤调整一致。
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kawayiYokami
kawayiYokami force-pushed the fix/lost-void-redetect-unstuck branch from d28a635 to 6ea708f Compare July 7, 2026 09:49
@kawayiYokami kawayiYokami changed the title 修复:脱困后无法重新检测丢失的虚空 fix: 脱困后无法重新检测丢失的虚空 Jul 7, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/zzz_od/application/shiyu_defense/shiyu_defense_app.py (1)

176-182: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

建议为新增分支补充说明性注释

同一函数内其余分支(如“等待多间模式画面加载”“检查是否有房间已打过”)均附有中文注释说明其用途,新增的确认按钮处理分支缺少类似注释,不利于后续维护者理解其修复背景(重置全部后可能出现确认弹窗)。As per path instructions, “注释应使用Google风格,函数职责较重时必须有注释”。

📝 建议补充注释
         if self.current_node_idx in MULTI_ROOM_NODES:
+            # 重置全部后可能出现确认弹窗,优先处理确认按钮
             result = self.round_by_find_area(self.last_screenshot, '式舆防卫战-三间选择', '确认')
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/zzz_od/application/shiyu_defense/shiyu_defense_app.py` around lines 176 -
182, In shiyu_defense_app.py, the new confirmation-button branch inside the
related function lacks the same explanatory Google-style comment used by the
other branches. Add a concise Chinese comment above the round_by_find_area /
round_by_click_area confirmation handling in this function to explain that this
path handles the confirmation popup that may appear after resetting all, so
future maintainers can understand the fix context.

Source: Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/zzz_od/application/shiyu_defense/shiyu_defense_app.py`:
- Around line 176-182: In shiyu_defense_app.py, the new confirmation-button
branch inside the related function lacks the same explanatory Google-style
comment used by the other branches. Add a concise Chinese comment above the
round_by_find_area / round_by_click_area confirmation handling in this function
to explain that this path handles the confirmation popup that may appear after
resetting all, so future maintainers can understand the fix context.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: adafdf69-43e6-4493-85ee-fffed3ac432e

📥 Commits

Reviewing files that changed from the base of the PR and between 8d018cf and d28a635.

📒 Files selected for processing (2)
  • src/zzz_od/application/hollow_zero/lost_void/operation/lost_void_move_by_det.py
  • src/zzz_od/application/shiyu_defense/shiyu_defense_app.py

@kawayiYokami
kawayiYokami marked this pull request as draft July 7, 2026 10:07
@kawayiYokami
kawayiYokami marked this pull request as ready for review July 7, 2026 10:13
@ShadowLemoon
ShadowLemoon merged commit 6621f95 into OneDragon-Anything:main Jul 8, 2026
8 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 11, 2026
@kawayiYokami
kawayiYokami deleted the fix/lost-void-redetect-unstuck branch July 11, 2026 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants