refactor: 重构迷失之地入口判断，兼容新账户 - #2503
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthrough迷失之地入口配置新增“探索收集”区域并补充按钮跳转目标。 Changes迷失之地导航
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant LostVoidApp
participant ScreenInfo
participant GameUI
LostVoidApp->>ScreenInfo: 查找入口按钮
ScreenInfo-->>LostVoidApp: 返回按钮识别结果
LostVoidApp->>GameUI: 点击周期或常规按钮
GameUI-->>ScreenInfo: 显示前往挑战或目标副本入口
LostVoidApp->>GameUI: 跳转目标副本屏幕
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/zzz_od/application/hollow_zero/lost_void/lost_void_app.py (1)
139-142: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value更新注释以匹配实际代码逻辑。
注释中提到“到达入口的判定只认‘常规’”，但下方的代码逻辑实际使用的是
按钮-战线肃清。建议修正注释以保持图文一致，避免给后续维护带来困扰。♻️ 建议的修改
- # 新入口UI：战线肃清/特遣调查需要先在“矩阵探索”页点击“常规”再点目标副本 - # 到达入口的判定只认“常规”，后续分流由入口导航节点按副本目标处理 + # 新入口UI：战线肃清/特遣调查需要先在“矩阵探索”页点击“常规”再点目标副本 + # 到达入口的判定使用“战线肃清”作为锚点，后续分流由入口导航节点按副本目标处理 if self.config.mission_name in ['战线肃清', '特遣调查']:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/zzz_od/application/hollow_zero/lost_void/lost_void_app.py` around lines 139 - 142, 更新 lost_void_app.py 中该入口导航条件前的注释，使其准确描述代码通过“按钮-战线肃清”进行入口判定的实际逻辑，并移除或修正“只认常规”的表述；不要修改下方的 round_by_find_area 调用或其他分流逻辑。
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/zzz_od/application/hollow_zero/lost_void/lost_void_app.py`:
- Around line 171-174: 在 LostVoid 应用中更新 round_by_find_area 的结果判断：将
result.is_fail 改为检查 not result.is_success，使未识别到“按钮-常规”时的 RETRY 和 FAIL 都立即调用
round_retry 并返回；成功状态保持现有 OCR 流程不变。
---
Nitpick comments:
In `@src/zzz_od/application/hollow_zero/lost_void/lost_void_app.py`:
- Around line 139-142: 更新 lost_void_app.py
中该入口导航条件前的注释，使其准确描述代码通过“按钮-战线肃清”进行入口判定的实际逻辑，并移除或修正“只认常规”的表述；不要修改下方的
round_by_find_area 调用或其他分流逻辑。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 86aab9c5-c906-445d-93ae-db0147aa9996
📒 Files selected for processing (3)
assets/game_data/screen_info/_od_merged.ymlassets/game_data/screen_info/lost_void_entry.ymlsrc/zzz_od/application/hollow_zero/lost_void/lost_void_app.py
ShadowLemoon
force-pushed
the
refactor/lost-void-entry
branch
from
July 17, 2026 01:51
89a1964 to
172108a
Compare
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
src/zzz_od/application/hollow_zero/lost_void/lost_void_app.py (1)
164-167: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win这里应直接判断成功状态。
round_by_find_area未命中时返回的是RETRY，result.is_fail只会拦截FAIL，会漏掉“未识别到常规按钮”的分支并继续执行后面的 OCR。建议改成not result.is_success更稳妥。💻 建议修复
- if result.is_fail: + if not result.is_success: return self.round_retry('未识别到常规按钮', wait=0.5)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/zzz_od/application/hollow_zero/lost_void/lost_void_app.py` around lines 164 - 167, Update the result check in the flow around round_by_find_area to use result.is_success as the success condition, returning round_retry when the result is not successful. This must handle both RETRY and FAIL outcomes before continuing to the subsequent OCR processing.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@src/zzz_od/application/hollow_zero/lost_void/lost_void_app.py`:
- Around line 164-167: Update the result check in the flow around
round_by_find_area to use result.is_success as the success condition, returning
round_retry when the result is not successful. This must handle both RETRY and
FAIL outcomes before continuing to the subsequent OCR processing.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9382f623-f683-4cd4-a236-2dcb9dce5ab5
📒 Files selected for processing (3)
assets/game_data/screen_info/_od_merged.ymlassets/game_data/screen_info/lost_void_entry.ymlsrc/zzz_od/application/hollow_zero/lost_void/lost_void_app.py
🚧 Files skipped from review as they are similar to previous changes (1)
- assets/game_data/screen_info/lost_void_entry.yml
Usagi-wusaqi
suggested changes
Jul 17, 2026
ShadowLemoon
force-pushed
the
refactor/lost-void-entry
branch
from
July 17, 2026 05:47
172108a to
b306a32
Compare
ShadowLemoon
force-pushed
the
refactor/lost-void-entry
branch
from
July 17, 2026 05:47
b306a32 to
c7b3719
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit