feat: 画面建档(防卫战/快捷手册)+ skill 方法论 + analyze_screen vision_hint - #2517
Merged
Conversation
…e-node Co-Authored-By: Claude Code <noreply@anthropic.com> Co-Authored-By: glm-5.2 <noreply@bigmodel.cn>
…e-node Co-Authored-By: Claude Code <noreply@anthropic.com> Co-Authored-By: glm-5.2 <noreply@bigmodel.cn>
- pr-review + pr-finishing: PR 合并后提示删本地 + remote 分支(只提示,不主动) - pr-review: 审 PR 时无论有无配套测试仓 PR,都先本地建同名分支占位(防补测试忘记切分支 → 误 commit 测试仓 main,即 #2348 的 4ca301d 教训) Co-Authored-By: Claude Code <noreply@anthropic.com>
战斗 app 首次建档(L4 导航触发):式舆防卫战选关主界面(前哨档案+节点01-05+剧变节点进度)+ 快捷手册(5 TAB 入口)+ 式舆防卫战玩法。截图归档测试仓 fix/issue-2506-defense-node 分支。 Co-Authored-By: Claude Code <noreply@anthropic.com>
- AGENTS.md 加「改/建 skill」节(触发 skill-guide + design.md + 写方法论,工具无关) - onboard skill:覆盖检查写方法论(去 mock_screen 等具体 API)+ source_image 归档后用 screens/<screen>/<state>.webp + 玩法 doc 触发 gameplay skill;design.md 同步 - convert_to_webp.py 加覆盖提醒 - 式舆防卫战 + 快捷手册 source_image 更新为归档 state 名完整路径 Co-Authored-By: Claude Code <noreply@anthropic.com> Co-Authored-By: glm-5.2 <noreply@bigmodel.cn>
23 个旧 doc 的 source_image 从 .debug 临时名/英文 fixture 名/只 state 名统一为 screens/<screen>/<state>.webp(自描述可找);顺带修正 doc 名 ≠ 测试仓名(3D地图 map_3d_default→默认、仓库 storage_drive_disc_default→默认、战斗画面 _xxx.png→默认/精英、大世界 _xxx→普通 等)。待补的吼吼饼铺/委托助手不动。 Co-Authored-By: Claude Code <noreply@anthropic.com> Co-Authored-By: glm-5.2 <noreply@bigmodel.cn>
Co-Authored-By: Claude Code <noreply@anthropic.com> Co-Authored-By: glm-5.2 <noreply@bigmodel.cn>
…e-node Co-Authored-By: Claude Code <noreply@anthropic.com> Co-Authored-By: glm-5.2 <noreply@bigmodel.cn>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough本次变更新增 Changes视觉能力边界提示
屏幕建档流程规范
玩法与屏幕资料更新
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/game/gameplay/式舆防卫战.md`:
- Around line 77-78: 统一“剧变节点”的刷新周期描述，依据已验证的游戏规则在 docs/game/gameplay/式舆防卫战.md
第77-78行保留或修正周期，并同步更新 docs/game/screens/式舆防卫战.md
第10行；确保两处使用完全一致的唯一表述，稳定/纷争节点说明保持不变。
In `@docs/game/screens/式舆防卫战.md`:
- Line 113: 统一 Line 113 与 Line 136 对防卫战结算画面的描述：围绕 screen_info 和
shiyu_defense.yml 明确其当前到底是仅有通用
area、尚未精准建模，还是已能可靠识别；根据实际实现同步两处表述，避免一处称未独立建模、另一处称已包含可识别的“战斗结束”子态。
In `@skills/zzz-od-dev-screen-onboarding/SKILL.md`:
- Around line 111-114: 更新 SKILL.md 的“转换”说明，移除 convert_to_webp.py
的仓库路径、命令示例及具体实现细节，仅保留使用 WebP 转换工具的方法论描述；将脚本路径和具体调用方式迁移到 design.md。
- Line 74: 统一 source_image 与测试 fixture 的职责：在
skills/zzz-od-dev-screen-onboarding/SKILL.md:74-74 保留 source_image 记录 .debug
原始截图 ID；在 skills/zzz-od-dev-screen-onboarding/SKILL.md:109-109 独立记录测试仓归档路径
screens/<screen>/<state>.webp；同步修改
skills/zzz-od-dev-screen-onboarding/design.md:49-49 的设计决策，避免传播将 fixture 路径作为
source_image 的错误契约。
In `@src/zzz_od/backend/backend_context.py`:
- Around line 539-540: 同步更新两个返回契约文档：在 src/zzz_od/backend/backend_context.py 的
analyze Returns 说明中补充 vision_hint，并注明成功时有值、失败时为 None；在
src/zzz_od/backend/http/routes.py 的 handle_game_analyze JSON 返回说明中补充
vision_hint，并注明失败时为 null。无需修改实际返回逻辑。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7daefe7d-78c2-4d08-83cd-a4fcd7cb29aa
📒 Files selected for processing (37)
AGENTS.mddocs/develop/zzz/backend/design-principles.mddocs/develop/zzz/backend/mcp.mddocs/game/gameplay/式舆防卫战.mddocs/game/screens/3D地图.mddocs/game/screens/README.mddocs/game/screens/丽都周纪.mddocs/game/screens/丽都城募.mddocs/game/screens/仓库-驱动仓库.mddocs/game/screens/兑换码输入.mddocs/game/screens/加载画面.mddocs/game/screens/卦象集录.mddocs/game/screens/咖啡店.mddocs/game/screens/地图.mddocs/game/screens/大世界.mddocs/game/screens/对话.mddocs/game/screens/式舆防卫战.mddocs/game/screens/影像店营业.mddocs/game/screens/快捷手册-日常.mddocs/game/screens/快捷手册.mddocs/game/screens/战斗画面.mddocs/game/screens/打开游戏.mddocs/game/screens/报刊亭.mddocs/game/screens/米哈游启动页.mddocs/game/screens/绝区零标题页.mddocs/game/screens/菜单-更多功能.mddocs/game/screens/警告_游戏前详阅.mddocs/game/screens/邮件.mddocs/game/screens/随便观.mddocs/game/screens/驱动盘拆解.mdskills/zzz-od-dev-screen-onboarding/SKILL.mdskills/zzz-od-dev-screen-onboarding/convert_to_webp.pyskills/zzz-od-dev-screen-onboarding/design.mdsrc/zzz_od/backend/backend_context.pysrc/zzz_od/backend/http/routes.pysrc/zzz_od/backend/mcp/app.pysrc/zzz_od/backend/schemas.py
…onvert_to_webp 移 design + vision_hint docstring) Co-Authored-By: Claude Code <noreply@anthropic.com> Co-Authored-By: glm-5.2 <noreply@bigmodel.cn>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/develop/zzz/screenshot_archive.md`:
- Line 33: 更新“更新溯源”流程说明，除 frontmatter 的 source_image
外，明确要求同步多子态画面各子态标题中的独立截图路径，确保识别快照引用新的归档图片；保留现有归档路径和 README 索引更新要求。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2467d185-6ade-47ff-ad7e-f8c6142a31b7
📒 Files selected for processing (6)
docs/develop/zzz/screenshot_archive.mddocs/game/screens/式舆防卫战.mdskills/zzz-od-dev-screen-onboarding/SKILL.mdskills/zzz-od-dev-screen-onboarding/design.mdsrc/zzz_od/backend/backend_context.pysrc/zzz_od/backend/http/routes.py
🚧 Files skipped from review as they are similar to previous changes (4)
- src/zzz_od/backend/http/routes.py
- skills/zzz-od-dev-screen-onboarding/design.md
- src/zzz_od/backend/backend_context.py
- skills/zzz-od-dev-screen-onboarding/SKILL.md
3 tasks
…eRabbit) Co-Authored-By: Claude Code <noreply@anthropic.com> Co-Authored-By: glm-5.2 <noreply@bigmodel.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动
1. analyze_screen 返回 vision_hint 能力边界提示(backend)
AnalyzeScreenResult增加vision_hint字段(success 时填):提醒智能体本结果仅含 OCR + 模板匹配的部分识别,需要全面判断画面时配合视觉工具 / 多模态再看(防把部分识别当画面全貌)。schemas/backend_context/mcp.app/http.routes(MCP + HTTP 对称)design-principles.md新增 P14(观察类工具可返回能力边界提示,含与 P1「capability over compensation」的边界论证)mcp.md补字段说明2. 式舆防卫战 + 快捷手册 画面建档
docs/game/screens/式舆防卫战.md(选关主界面 + 子态:弱点/编队/战斗/阶段切换/入口交互/挑战结果/领奖/多间)docs/game/screens/快捷手册.md(目标 / 作战 TAB)docs/game/gameplay/式舆防卫战.md(玩法 doc)3. onboard skill 方法论强化
skills/zzz-od-dev-screen-onboarding/(SKILL.md + design.md):覆盖检查、source_image 归档路径规范、强制触发 gameplay-onboardingconvert_to_webp.py覆盖提醒4. AGENTS.md + pr 类 skill
pr-finishing/pr-reviewskill 补合并后删分支提示 + 测试仓分支占位方法论5. 23 个画面 doc source_image 统一
统一为测试仓相对路径
screens/<screen>/<state>.webp(自描述可找)。测试配套
测试仓 PR #19:OneDragon-Anything/zzz-od-test#19
(防卫战 / 快捷手册 fixture + vision_hint 断言)
验证
analyze_screen返回 JSON 含vision_hint(server 重启后实时验证通过)Summary by CodeRabbit
/game/analyze与 MCPanalyze_screen返回新增vision_hint能力边界提示（成功返回；失败为 null）。