Only default to Global for the global MoleculeProperties container

Addresses review feedback: new parameters in local MoleculeProperties
containers must stay Local. Only the global MoleculeProperties container,
a special member of the SpatialStructure (marked ContainerType.Molecule),
should default to Global. Introduce IsGlobalMoleculeProperties() to make
that distinction and use it in DefaultParameterBuildMode.

Author: rwmcintosh

src/MoBi.Core/Domain/Extensions/ContainerExtensions.cs

@@ -26,7 +26,7 @@ public static ParameterBuildMode DefaultParameterBuildMode(this IContainer conta
          var needsGlobalParameter = container.IsAnImplementationOf<TransporterMoleculeContainer>() ||
                                     container.IsAnImplementationOf<ReactionBuilder>() ||
                                     container.IsAnImplementationOf<InteractionContainer>() ||
-                                    container.IsMoleculeProperties();
+                                    container.IsGlobalMoleculeProperties();
 
          return needsGlobalParameter ? ParameterBuildMode.Global : ParameterBuildMode.Local;
       }

src/MoBi.Core/Domain/Extensions/EntityExtensions.cs

@@ -16,6 +16,16 @@ public static bool IsMoleculeProperties(this IContainer container)
          return container.IsNamed(Constants.MOLECULE_PROPERTIES);
       }
 
+      /// <summary>
+      ///    Returns <c>true</c> for the global <c>MoleculeProperties</c> container that is a special member of a
+      ///    <see cref="OSPSuite.Core.Domain.Builder.SpatialStructure" /> (created with <see cref="ContainerType.Molecule" />),
+      ///    as opposed to the local <c>MoleculeProperties</c> containers nested in physical containers.
+      /// </summary>
+      public static bool IsGlobalMoleculeProperties(this IContainer container)
+      {
+         return container.IsMoleculeProperties() && container.ContainerType == ContainerType.Molecule;
+      }
+
       public static bool IsAtMoleculeBuilder(this IEntity entity)
       {
          return entity.RootContainer.IsAnImplementationOf<MoleculeBuilder>();

tests/MoBi.Tests/Core/Commands/AddParameterToContainerCommandSpecs.cs

@@ -75,11 +75,11 @@ protected override ParameterBuildMode GetBuildModeType()
       }
    }
 
-   public class When_adding_a_new_parameter_to_molecule_properties_container : When_testing_for_appropriate_parameter_build_modes
+   public class When_adding_a_new_parameter_to_the_global_molecule_properties_container : When_testing_for_appropriate_parameter_build_modes
    {
       protected override IContainer GetContainer()
       {
-         return new Container().WithName(Constants.MOLECULE_PROPERTIES);
+         return new Container().WithName(Constants.MOLECULE_PROPERTIES).WithContainerType(ContainerType.Molecule);
       }
 
       protected override ParameterBuildMode GetBuildModeType()
@@ -88,6 +88,19 @@ protected override ParameterBuildMode GetBuildModeType()
       }
    }
 
+   public class When_adding_a_new_parameter_to_a_local_molecule_properties_container : When_testing_for_appropriate_parameter_build_modes
+   {
+      protected override IContainer GetContainer()
+      {
+         return new Container().WithName(Constants.MOLECULE_PROPERTIES).WithContainerType(ContainerType.Compartment);
+      }
+
+      protected override ParameterBuildMode GetBuildModeType()
+      {
+         return ParameterBuildMode.Local;
+      }
+   }
+
    public class When_adding_a_new_parameter_to_a_generic_container : When_testing_for_appropriate_parameter_build_modes
    {
       protected override IContainer GetContainer()