Skip to content

Commit e20a434

Browse files
rwmcintoshrwmcintosh
authored
Remove dead code (#2412)
* Remove dead code Remove unused C# types, members, mappers, and self-contained presenter/view clusters (with their orphaned .resx), and inline the single-use EditBuildingBlockStarter pass-through into ModuleExplorerPresenter. No functional change; build and MoBi unit/UI/R test suites green. * Rename stale test observation to match its assertion The molecule double-click test kept the context-menu observation name copied from the sibling test; it actually verifies the edit task is invoked. * Remove dead code referenced only by tests DataNamingService, ReportingHelper (MoBi.Core) and ValuePointFormatter (MoBi.Presentation) had no production references, only their own specs. The two MoBi.Core types were also verified unreachable from R (rSharp/OSPSuite-R). * Remove dead code in MoBi.Core (R-manifest-cleared) Five unused types in the R-reachable MoBi.Core assembly, confirmed unreferenced and absent from the OSPSuite-R reflection manifest: MergeCanceledEvent (event never published), IMergeTask (no implementor), InvalidBuildConfigurationException (never thrown), ProjectConverterMessage with its ConverterMessageType enum (never created), and MergedDimensionFactoryExtensions (GetDimensionForChart never called). * remove unused * update core
1 parent 902787e commit e20a434

135 files changed

Lines changed: 52 additions & 4981 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/MoBi.Assets/MoBi.Assets.csproj‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
</ItemGroup>
2323

2424
<ItemGroup>
25-
<PackageReference Include="OSPSuite.Assets" Version="13.0.118" />
26-
<PackageReference Include="OSPSuite.Assets.Images" Version="13.0.118" />
27-
<PackageReference Include="OSPSuite.Core" Version="13.0.118" />
25+
<PackageReference Include="OSPSuite.Assets" Version="13.0.119" />
26+
<PackageReference Include="OSPSuite.Assets.Images" Version="13.0.119" />
27+
<PackageReference Include="OSPSuite.Core" Version="13.0.119" />
2828
</ItemGroup>
2929

3030
<ItemGroup>

‎src/MoBi.BatchTool/MoBi.BatchTool.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
</ItemGroup>
4141
<ItemGroup>
4242
<PackageReference Include="DevExpress.Win.Design" Version="25.2.7" Condition="'$(ExcludeDesigner)' != 'true'" />
43-
<PackageReference Include="OSPSuite.Core" Version="13.0.118" />
43+
<PackageReference Include="OSPSuite.Core" Version="13.0.119" />
4444
<PackageReference Include="OSPSuite.FuncParser" Version="5.0.0.3" />
4545
<PackageReference Include="OSPSuite.SimModel" Version="5.0.0.76" />
4646
<PackageReference Include="OSPSuite.SimModelSolver_CVODES" Version="5.0.0.53" />

‎src/MoBi.CLI.Core/MoBi.CLI.Core.csproj‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@
1616

1717

1818
<ItemGroup>
19-
<PackageReference Include="OSPSuite.Assets" Version="13.0.118" />
20-
<PackageReference Include="OSPSuite.Infrastructure.Autofac" Version="13.0.118" />
19+
<PackageReference Include="OSPSuite.Assets" Version="13.0.119" />
20+
<PackageReference Include="OSPSuite.Infrastructure.Autofac" Version="13.0.119" />
2121
<PackageReference Include="OSPSuite.Utility" Version="5.0.0.7" />
22-
<PackageReference Include="OSPSuite.Core" Version="13.0.118" />
23-
<PackageReference Include="OSPSuite.R" Version="13.0.118" />
24-
<PackageReference Include="OSPSuite.Infrastructure" Version="13.0.118" />
25-
<PackageReference Include="OSPSuite.Infrastructure.Castle" Version="13.0.118" />
22+
<PackageReference Include="OSPSuite.Core" Version="13.0.119" />
23+
<PackageReference Include="OSPSuite.R" Version="13.0.119" />
24+
<PackageReference Include="OSPSuite.Infrastructure" Version="13.0.119" />
25+
<PackageReference Include="OSPSuite.Infrastructure.Castle" Version="13.0.119" />
2626
</ItemGroup>
2727
<ItemGroup>
2828
<ProjectReference Include="..\MoBi.Assets\MoBi.Assets.csproj" />

‎src/MoBi.CLI/MoBi.CLI.csproj‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@
2121
<ItemGroup>
2222
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="9.0.6" />
2323
<PackageReference Include="CommandLineParser" Version="2.9.1" />
24-
<PackageReference Include="OSPSuite.Core" Version="13.0.118" />
25-
<PackageReference Include="OSPSuite.Assets" Version="13.0.118" />
24+
<PackageReference Include="OSPSuite.Core" Version="13.0.119" />
25+
<PackageReference Include="OSPSuite.Assets" Version="13.0.119" />
2626
<PackageReference Include="OSPSuite.Utility" Version="5.0.0.7" />
2727
<PackageReference Include="OSPSuite.FuncParser" Version="5.0.0.3" />
2828
<PackageReference Include="OSPSuite.SimModel" Version="5.0.0.76" />
2929
<PackageReference Include="OSPSuite.SimModelSolver_CVODES" Version="5.0.0.53" />
3030
<PackageReference Include="SixLabors.ImageSharp" Version="2.1.11" />
31-
<PackageReference Include="OSPSuite.Infrastructure" Version="13.0.118" />
32-
<PackageReference Include="OSPSuite.Infrastructure.Castle" Version="13.0.118" />
31+
<PackageReference Include="OSPSuite.Infrastructure" Version="13.0.119" />
32+
<PackageReference Include="OSPSuite.Infrastructure.Castle" Version="13.0.119" />
3333
</ItemGroup>
3434
<ItemGroup>
3535
<Content Include="..\..\dimensions\OSPSuite.Dimensions.xml" Link="OSPSuite.Dimensions.xml">

‎src/MoBi.Core/Commands/ResetQuantityValuesToDefaultFromPathAndValueEntitiesInSimulation.cs‎

Lines changed: 0 additions & 76 deletions
This file was deleted.

‎src/MoBi.Core/Domain/Model/InvalidBuildConfigurationException.cs‎

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎src/MoBi.Core/Domain/Services/DataNamingService.cs‎

Lines changed: 0 additions & 44 deletions
This file was deleted.

‎src/MoBi.Core/Events/MergeCanceledEvent.cs‎

Lines changed: 0 additions & 6 deletions
This file was deleted.

‎src/MoBi.Core/Helper/MergedDimensionFactoryExtensions.cs‎

Lines changed: 0 additions & 16 deletions
This file was deleted.

‎src/MoBi.Core/Helper/ReportingHelper.cs‎

Lines changed: 0 additions & 53 deletions
This file was deleted.

0 commit comments

Comments
 (0)