Fixes #2427 Rename of cloned expression profile updates parameter and initial condition paths (#2433)

Extract expression-profile renaming into a shared ExpressionProfileRenamingTask that sets the name and syncs the molecule in expression parameter and initial condition paths. Use it from the RenameObjectBaseCommand switch and from the clone flow (RenameClone) so cloning a profile with a new molecule name updates its paths.

Author: rwmcintosh

src/MoBi.Core/Commands/RenameExpressionProfileBuildingBlockCommand.cs

@@ -53,6 +53,10 @@ protected virtual void RenameObjectBase(IMoBiContext context)
 
          switch (_objectBase)
          {
+            case ExpressionProfileBuildingBlock expressionProfile:
+               context.Resolve<IExpressionProfileRenamingTask>().Rename(expressionProfile, _newName);
+               renameInSimulationTask.RenameInSimulationUsingTemplateBuildingBlock(OldName, expressionProfile);
+               break;
             case IBuildingBlock buildingBlock:
                _objectBase.Name = _newName;
                renameInSimulationTask.RenameInSimulationUsingTemplateBuildingBlock(OldName, buildingBlock);

src/MoBi.Core/Commands/RenameObjectBaseCommand.cs

@@ -0,0 +1,34 @@
+using OSPSuite.Core.Domain.Builder;
+using OSPSuite.Utility.Extensions;
+
+namespace MoBi.Core.Domain.Services
+{
+   public interface IExpressionProfileRenamingTask
+   {
+      /// <summary>
+      ///    Renames the <paramref name="expressionProfile" /> to <paramref name="newName" /> and updates the molecule name in the
+      ///    paths of all expression parameters and initial conditions accordingly.
+      /// </summary>
+      void Rename(ExpressionProfileBuildingBlock expressionProfile, string newName);
+   }
+
+   public class ExpressionProfileRenamingTask : IExpressionProfileRenamingTask
+   {
+      public void Rename(ExpressionProfileBuildingBlock expressionProfile, string newName)
+      {
+         var oldMoleculeName = expressionProfile.MoleculeName;
+         expressionProfile.Name = newName;
+         var newMoleculeName = expressionProfile.MoleculeName;
+
+         expressionProfile.ExpressionParameters.Each(x => renameMoleculeInPath(x, oldMoleculeName, newMoleculeName));
+         expressionProfile.InitialConditions.Each(x => renameMoleculeInPath(x, oldMoleculeName, newMoleculeName));
+      }
+
+      private static void renameMoleculeInPath(PathAndValueEntity entity, string oldMoleculeName, string newMoleculeName)
+      {
+         var objectPath = entity.Path;
+         objectPath.Replace(oldMoleculeName, newMoleculeName);
+         entity.Path = objectPath;
+      }
+   }
+}

src/MoBi.Core/Domain/Services/ExpressionProfileRenamingTask.cs

@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using System.Linq;
-using MoBi.Core.Commands;
 using MoBi.Presentation.Presenter;
 using MoBi.Presentation.Tasks.Interaction;
 using OSPSuite.Core.Domain;
@@ -36,10 +35,5 @@ protected override IEnumerable<string> GetUnallowedNames(ExpressionProfileBuildi
       {
          return base.GetUnallowedNames(objectBase, existingObjectsInParent).Concat(_interactionTaskContext.BuildingBlockRepository.ExpressionProfileCollection.AllNames());
       }
-
-      protected override IMoBiCommand GetRenameCommandFor(ExpressionProfileBuildingBlock expressionProfileBuildingBlock, IBuildingBlock buildingBlock, string newName, string objectType)
-      {
-         return new RenameExpressionProfileBuildingBlockCommand(expressionProfileBuildingBlock, newName, buildingBlock) { ObjectType = objectType };
-      }
    }
 }

src/MoBi.Presentation/Tasks/Edit/EditTasksForExpressionProfileBuildingBlock.cs

@@ -30,6 +30,7 @@ public class InteractionTasksForExpressionProfileBuildingBlock : InteractionTask
       private readonly IEditTasksForExpressionProfileBuildingBlock _editTaskForExpressionProfileBuildingBlock;
       private readonly IPKSimStarter _pkSimStarter;
       private readonly IContainerTask _containerTask;
+      private readonly IExpressionProfileRenamingTask _expressionProfileRenamingTask;
 
       public InteractionTasksForExpressionProfileBuildingBlock(IInteractionTaskContext interactionTaskContext,
          IEditTasksForExpressionProfileBuildingBlock editTask,
@@ -39,7 +40,8 @@ public InteractionTasksForExpressionProfileBuildingBlock(IInteractionTaskContext
          IPathAndValueEntityToDistributedParameterMapper pathAndValueEntityToDistributedParameterMapper,
          IExportDataTableToExcelTask exportDataTableToExcelTask,
          ICloneManagerForBuildingBlock cloneManager,
-         IExpressionProfileBuildingBlockToDataTableMapper mapper) :
+         IExpressionProfileBuildingBlockToDataTableMapper mapper,
+         IExpressionProfileRenamingTask expressionProfileRenamingTask) :
          base(interactionTaskContext,
             editTask,
             formulaTask,
@@ -51,8 +53,11 @@ public InteractionTasksForExpressionProfileBuildingBlock(IInteractionTaskContext
          _editTaskForExpressionProfileBuildingBlock = editTask;
          _pkSimStarter = pkSimStarter;
          _containerTask = containerTask;
+         _expressionProfileRenamingTask = expressionProfileRenamingTask;
       }
 
+      protected override void RenameClone(ExpressionProfileBuildingBlock clone, string newName) => _expressionProfileRenamingTask.Rename(clone, newName);
+
       public IMoBiCommand UpdateExpressionProfileFromDatabase(ExpressionProfileBuildingBlock buildingBlock)
       {
          var expressionProfileUpdate = _pkSimStarter.UpdateExpressionProfileFromDatabase(buildingBlock);

src/MoBi.Presentation/Tasks/Interaction/InteractionTasksForExpressionProfileBuildingBlock.cs

@@ -49,11 +49,14 @@ public IMoBiCommand Clone(TBuildingBlock buildingBlockToClone)
          if (string.IsNullOrEmpty(name))
             return new MoBiEmptyCommand();
 
-         var clone = InteractionTask.Clone(buildingBlockToClone).WithName(name);
+         var clone = InteractionTask.Clone(buildingBlockToClone);
+         RenameClone(clone, name);
 
          return AddToProject(clone);
       }
 
+      protected virtual void RenameClone(TBuildingBlock clone, string newName) => clone.WithName(newName);
+
       public void ExportBuildingBlockSnapshot(TBuildingBlock buildingBlock)
       {
          var filePath = InteractionTask.AskForFileToSave(AppConstants.Captions.SaveModuleSnapshot, Constants.Filter.JSON_FILE_FILTER, Constants.DirectoryKey.MODEL_PART, buildingBlock.Name);

src/MoBi.Presentation/Tasks/Interaction/InteractionTasksForProjectPathAndValueEntityBuildingBlocks.cs

@@ -130,4 +130,36 @@ public void the_renaming_task_is_used_to_rename_the_module()
          A.CallTo(() => _renameInSimulationTask.RenameInSimulationUsingTemplateModule("oldName", _module)).MustHaveHappened();
       }
    }
+
+   public class When_renaming_an_expression_profile : concern_for_RenameObjectBaseCommand
+   {
+      private ExpressionProfileBuildingBlock _expressionProfile;
+      private IExpressionProfileRenamingTask _expressionProfileRenamingTask;
+
+      protected override void Context()
+      {
+         _expressionProfile = new ExpressionProfileBuildingBlock().WithName("OldMolecule|Species|Category").WithId("id");
+         base.Context();
+         _expressionProfileRenamingTask = A.Fake<IExpressionProfileRenamingTask>();
+         A.CallTo(() => _context.Resolve<IExpressionProfileRenamingTask>()).Returns(_expressionProfileRenamingTask);
+      }
+
+      protected override void Because() => sut.Execute(_context);
+
+      protected override IBuildingBlock GetBuildingBlock() => null;
+
+      protected override IObjectBase GetObject() => _expressionProfile;
+
+      [Observation]
+      public void the_expression_profile_renaming_task_renames_the_building_block_and_updates_its_paths()
+      {
+         A.CallTo(() => _expressionProfileRenamingTask.Rename(_expressionProfile, "newName")).MustHaveHappened();
+      }
+
+      [Observation]
+      public void the_rename_is_propagated_to_simulations()
+      {
+         A.CallTo(() => _renameInSimulationTask.RenameInSimulationUsingTemplateBuildingBlock("OldMolecule|Species|Category", _expressionProfile)).MustHaveHappened();
+      }
+   }
 }