Skip to content

Support MIN/MAX in limits #3501

Description

@shonigmann

What is the use case or problem this feature would solve?

Our team has noticed that the limit set notation is relatively rigid. e.g. to add a limit set for a telemetry point:

  • there must be a DEFAULT limit definition, before a limit set can be defined
    • at least as of our testing in OpenC3 6.4.2, the DEFAULT limit must come first in the telemetry definition, e.g. the following is rejected:
          LIMITS SET_A 1 ENABLED -10 -5 10 20
          LIMITS DEFAULT 1 ENABLED -10 -5 10 20
      
      with:
      Error: DEFAULT limits set must be defined for XXX YYY ZZZ before setting limits set SET_A
      
    • we haven't yet tested in OpenC3 v7
  • require all 4 red and yellow high and low states

What we haven't figured out how to do is:

  • one-sided limits (e.g. only yellow_high / red_high, leaving the low side unbounded)
  • no-op DEFAULT limits (e.g. only apply limits when a set is loaded)

Are either of the above possible?

Describe the solution you'd like

  • OpenC3 supports 1-sided limits (e.g. by supporting MIN/MAX like in command parameter constraints or otherwise make red/yellow limits optional
  • OpenC3 supports optional or no-op DEFAULT limits

Additional context

No response

Screenshots

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Fields

    No fields configured for Feature.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions