Skip to content

Commit 95e8011

Browse files
AlfVIIclaude
andcommitted
docs(vienna): refresh file-header to reflect Phase-3 complete
After landing Items 2-6 in commits 1b01a42, 8fa150a, f2fb21c the Vienna.cpp file-level docblock still listed those items as "Deferred (throws on use, planned next)" — only matched the state after Item 1. VIENNA_PHASE3_PLAN.md was already updated to "COMPLETE"; this just brings the inline doc in sync. No code change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 21abe9e commit 95e8011

1 file changed

Lines changed: 21 additions & 14 deletions

File tree

src/converter_models/Vienna.cpp

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,30 @@
11
// =====================================================================
2-
// Vienna rectifier — Phase 1+2+3 (incremental).
2+
// Vienna rectifier — Phase 1+2+3 (complete).
33
//
44
// Phase 1: skeleton (constructor, run_checks, design-requirements stub).
55
// Phase 2: per-phase analytical solver at peak-of-line (single sample).
6-
// Phase 3 (this file): adds samplingStrategy=fullLineCycle — each of the
7-
// three "Phase A/B/C" windings carries the full 50/60 Hz line cycle,
8-
// shifted by 120° per phase, so the wizard plot shows a recognisable
9-
// 3-phase pattern instead of three identical peak-of-line snapshots.
10-
// The remaining Phase-3 items (viennaII, alternative switch types,
11-
// synchronousRectifier, phaseCount>1, peakOfLinePlusSectors) are
12-
// gated separately in run_checks and documented in VIENNA_PHASE3_PLAN.md.
6+
// Phase 3: every previously-deferred item shipped (see VIENNA_PHASE3_PLAN.md):
7+
// - Item 1 — samplingStrategy=fullLineCycle: each of the three
8+
// "Phase A/B/C" windings carries the full 50/60 Hz line cycle,
9+
// shifted by 120° per phase, so the wizard plot shows a
10+
// recognisable 3-phase pattern instead of three identical
11+
// peak-of-line snapshots.
12+
// - Item 2 — samplingStrategy=peakOfLinePlusSectors: 6 OPs per
13+
// input op, one per DPWM sector mid-point (30°/…/330°).
14+
// - Item 3 — viennaVariant=viennaII: 2-switch-per-leg bidirectional
15+
// clamp; per-switch RMS/avg = ½ Vienna I (Friedli/Kolar §IV.B).
16+
// - Item 4 — switchType ∈ {tType, backToBackMosfet,
17+
// singleMosfetIn4DiodeBridge}: routed analytically.
18+
// - Item 5 — synchronousRectifier: boost-diode avg/rms diagnostics
19+
// populated; sync-rec MOSFET conduction loss = Rds·I_rms².
20+
// - Item 6 — phaseCount>1: N interleaved channels per phase;
21+
// L scales to L_single/N; emits 3·N windings ("Phase X ch K").
1322
//
14-
// Deferred (throws on use, planned next):
15-
// - samplingStrategy=peakOfLinePlusSectors
16-
// - viennaII variant, backToBackMosfet / singleMosfetIn4DiodeBridge
17-
// switch types, synchronousRectifier, phaseCount > 1.
18-
// - Neutral-point voltage-ripple modelling (NP balancing controller).
23+
// Cross-cutting items still pending (not gated; just not modelled):
24+
// - Neutral-point voltage-ripple (NP balancing controller).
1925
// - DC-bus capacitor sizing.
20-
// - SPICE netlist emission for the full 3-phase circuit.
26+
// - True 3-phase SPICE netlist (current SPICE path is the
27+
// Phase-1 single-phase boost emulator at peak-of-line).
2128
//
2229
// REFERENCES
2330
// [1] Kolar & Zach, PCIM 1994 (the original Vienna paper).

0 commit comments

Comments
 (0)