db: register PyMySQL as MySQLdb so mysql:// URLs work without +pymysql

Call pymysql.install_as_MySQLdb() on startup so SQLAlchemy's mysql://
dialect picks up PyMySQL automatically. Revert all mysql+pymysql:// URLs
back to mysql:// in defaults, docs, tests, and the database module.

Author: dariusstefan

docs/modules/database.md

@@ -41,10 +41,10 @@ are using the OpenSIPS source tree.  Default: `/usr/share/opensips`
 (administrator) access level which will be used to create/drop databases, as
 well as to create or ensure access for the non-privileged DB access user
 provided via `database_url`.  The URL combines schema, username, password, host
-and port.  Default: `mysql+pymysql://root@localhost`.
+and port.  Default: `mysql://root@localhost`.
 * `database_url` (optional) - the connection string to the database.  A good practice
 would be to use a non-administrator access user for this URL.  Default:
-`mysql+pymysql://opensips:opensipsrw@localhost`.
+`mysql://opensips:opensipsrw@localhost`.
 * `database_name` (optional) - the name of the database.  Modules may be separately added
 to this database if you choose not to install all of them.  Default: `opensips`.
 * `database_modules` (optional) - accepts the `ALL` keyword that indicates all the
@@ -68,7 +68,7 @@ Consider the following configuration file:
 database_modules: ALL
 
 #database_admin_url: postgresql://root@localhost
-database_admin_url: mysql+pymysql://root@localhost
+database_admin_url: mysql://root@localhost
 ```
 
 The following command will create the `opensips` database and all possible

opensipscli/db.py

@@ -42,6 +42,8 @@
     # PostgreSQL on Bullseye; 0.41.x is required for SA 2.0); the shim is
     # tested against SA 1.3–2.0 and behaves consistently
     from opensipscli.libs import sqlalchemy_utils
+    import pymysql
+    pymysql.install_as_MySQLdb()
 except ImportError:
     logger.info("sqlalchemy not available!")
     sqlalchemy_available = False

opensipscli/defaults.py

@@ -71,7 +71,7 @@
     "datagram_buffer_size": "65535",
 
     # database module
-    "database_url": "mysql+pymysql://opensips:opensipsrw@localhost",
+    "database_url": "mysql://opensips:opensipsrw@localhost",
     "database_name": "opensips",
     "database_schema_path": "/usr/share/opensips",
 

test/alltests.py

@@ -26,17 +26,17 @@ def testMakeURL(self):
         assert repr(u) == 'x://user:***@host:12/db'
         assert str(u) == 'x://user:pass@host:12/db'
 
-        u = make_url('mysql+pymysql://opensips:opensipsrw@localhost/opensips')
-        assert repr(u) == 'mysql+pymysql://opensips:***@localhost/opensips'
-        assert str(u) == 'mysql+pymysql://opensips:opensipsrw@localhost/opensips'
+        u = make_url('mysql://opensips:opensipsrw@localhost/opensips')
+        assert repr(u) == 'mysql://opensips:***@localhost/opensips'
+        assert str(u) == 'mysql://opensips:opensipsrw@localhost/opensips'
 
-        u = make_url('mysql+pymysql://opensips:opensipsrw@localhost')
-        assert repr(u) == 'mysql+pymysql://opensips:***@localhost'
-        assert str(u) == 'mysql+pymysql://opensips:opensipsrw@localhost'
+        u = make_url('mysql://opensips:opensipsrw@localhost')
+        assert repr(u) == 'mysql://opensips:***@localhost'
+        assert str(u) == 'mysql://opensips:opensipsrw@localhost'
 
-        u = make_url('mysql+pymysql://root@localhost')
-        assert repr(u) == 'mysql+pymysql://root@localhost'
-        assert str(u) == 'mysql+pymysql://root@localhost'
+        u = make_url('mysql://root@localhost')
+        assert repr(u) == 'mysql://root@localhost'
+        assert str(u) == 'mysql://root@localhost'
 
 
 if __name__ == "__main__":

test/test-database.sh

@@ -20,7 +20,7 @@
 CLI_CFG=/tmp/.__cli.cfg
 DB_NAME=_opensips_cli_test
 
-MYSQL_URL=mysql+pymysql://opensips:opensipsrw@localhost
+MYSQL_URL=mysql://opensips:opensipsrw@localhost
 PGSQL_URL=postgresql://opensips:opensipsrw@localhost
 
 TESTS=(