Merge pull request #177 from OpenSPP/fix/user-role-assignment-issue

fix(spp_user_roles): prevent validation error when assigning groups to a new role

Author: emjay0921

spp_user_roles/README.rst

@@ -129,6 +129,20 @@ Dependencies
 Changelog
 =========
 
+19.0.2.0.1
+~~~~~~~~~~
+
+- fix(role): allow assigning groups to a brand-new role in a single
+  save. Clicking **Add a line** in the role form's Groups tab used to
+  trigger inline creation of a blank ``res.groups`` row, which raised a
+  required-field validation error and aborted the save. The
+  ``implied_ids`` field's inner list now uses ``create="0"`` so the
+  button opens an "Add" picker against existing groups, and
+  ``res.users.role.create()`` extracts ``implied_ids`` before
+  ``super().create()`` and writes them to the role's ``group_id``
+  afterwards — mirroring the existing ``write()`` workaround in
+  ``base_user_role`` for the same ``_inherits`` cache-clearing bug.
+
 19.0.2.0.0
 ~~~~~~~~~~
 

spp_user_roles/__manifest__.py

@@ -2,7 +2,7 @@
 {
     "name": "OpenSPP User Roles",
     "category": "OpenSPP",
-    "version": "19.0.2.0.0",
+    "version": "19.0.2.0.1",
     "sequence": 1,
     "author": "OpenSPP.org",
     "website": "https://github.com/OpenSPP/OpenSPP2",

spp_user_roles/models/role.py

@@ -2,7 +2,7 @@
 
 import logging
 
-from odoo import fields, models
+from odoo import api, fields, models
 
 _logger = logging.getLogger(__name__)
 
@@ -12,6 +12,29 @@ class ResUsersRoleCustomSPP(models.Model):
 
     role_type = fields.Selection([("local", "Local"), ("global", "Global")], default="global")
 
+    @api.model_create_multi
+    def create(self, vals_list):
+        # Workaround: same Odoo cache-clearing bug as in base_user_role's write()
+        # override. When res.groups fields are set via _inherits on create(),
+        # implied_ids gets dropped. Extract group fields and write them to
+        # group_id directly after creation, mirroring the write() fix.
+        groups_vals_list = []
+        group_fields = set(self.env["res.groups"]._fields) - {"name"}
+        for vals in vals_list:
+            group_vals = {}
+            for field in group_fields:
+                if field in vals:
+                    group_vals[field] = vals.pop(field)
+            groups_vals_list.append(group_vals)
+
+        new_records = super().create(vals_list)
+
+        for record, group_vals in zip(new_records, groups_vals_list, strict=True):
+            if group_vals:
+                record.group_id.write(group_vals)
+
+        return new_records
+
     def action_update_users(self):
         """
         Call the update_users function to force the update of associated users in the role.

spp_user_roles/readme/HISTORY.md

@@ -1,3 +1,7 @@
+### 19.0.2.0.1
+
+- fix(role): allow assigning groups to a brand-new role in a single save. Clicking **Add a line** in the role form's Groups tab used to trigger inline creation of a blank `res.groups` row, which raised a required-field validation error and aborted the save. The `implied_ids` field's inner list now uses `create="0"` so the button opens an "Add" picker against existing groups, and `res.users.role.create()` extracts `implied_ids` before `super().create()` and writes them to the role's `group_id` afterwards — mirroring the existing `write()` workaround in `base_user_role` for the same `_inherits` cache-clearing bug.
+
 ### 19.0.2.0.0
 
 - Initial migration to OpenSPP2

spp_user_roles/static/description/index.html

@@ -503,6 +503,21 @@ <h2><a class="toc-backref" href="#toc-entry-1">Changelog</a></h2>
 </div>
 </div>
 <div class="section" id="section-1">
+<h1>19.0.2.0.1</h1>
+<ul class="simple">
+<li>fix(role): allow assigning groups to a brand-new role in a single
+save. Clicking <strong>Add a line</strong> in the role form’s Groups tab used to
+trigger inline creation of a blank <tt class="docutils literal">res.groups</tt> row, which raised a
+required-field validation error and aborted the save. The
+<tt class="docutils literal">implied_ids</tt> field’s inner list now uses <tt class="docutils literal"><span class="pre">create=&quot;0&quot;</span></tt> so the
+button opens an “Add” picker against existing groups, and
+<tt class="docutils literal">res.users.role.create()</tt> extracts <tt class="docutils literal">implied_ids</tt> before
+<tt class="docutils literal"><span class="pre">super().create()</span></tt> and writes them to the role’s <tt class="docutils literal">group_id</tt>
+afterwards — mirroring the existing <tt class="docutils literal">write()</tt> workaround in
+<tt class="docutils literal">base_user_role</tt> for the same <tt class="docutils literal">_inherits</tt> cache-clearing bug.</li>
+</ul>
+</div>
+<div class="section" id="section-2">
 <h1>19.0.2.0.0</h1>
 <ul class="simple">
 <li>Initial migration to OpenSPP2</li>

spp_user_roles/views/role.xml

@@ -20,9 +20,19 @@
             <xpath expr="//field[@name='name']" position="after">
                 <field name="role_type" />
             </xpath>
+            <!-- Restrict the Groups m2m to access groups not already
+                 owned by another role, and embed a list view that
+                 disables inline creation (avoids OP#979's "Add a line
+                 creates a new empty record" trap). Done via attributes
+                 + inside instead of replace so the OCA xml-view-
+                 dangerous-replace check stays happy. -->
             <xpath expr="//field[@name='implied_ids']" position="attributes">
                 <attribute name="domain">[('role_id', '=', False)]</attribute>
-                <attribute name="widget">many2many</attribute>
+            </xpath>
+            <xpath expr="//field[@name='implied_ids']" position="inside">
+                <list create="0">
+                    <field name="full_name" string="Group" />
+                </list>
             </xpath>
             <xpath
                 expr="//field[@name='line_ids']/list/field[@name='user_id']"