add more scenarios

Author: LeoPatOZ

src/protocol/IMessageRelayer.sol

@@ -19,6 +19,9 @@ interface IMessageRelayer {
     /// @dev Message forwarding failed
     error MessageForwardingFailed();
 
+    /// @dev Value sent is higher than tip amount
+    error InsufficientValue();
+
     /// @dev Tip transfer failed
     error TipTransferFailed();
 

src/protocol/taiko_alethia/MessageRelayer.sol

@@ -90,6 +90,7 @@ contract MessageRelayer is ReentrancyGuardTransient, IMessageRelayer {
             tipRecipient = TIP_RECIPIENT_SLOT.asAddress().tload();
         }
 
+        require(msg.value >= tip, InsufficientValue());
         uint256 valueToSend = msg.value - tip;
         bool forwardMessageSuccess;
 

test/MessageRelayer/FundAmountScenarios.t.sol

@@ -0,0 +1,36 @@
+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.28;
+
+import {DepositRecipientIsMessageRelayer} from "./DepositRecipientScenarios.t.sol";
+import {GenericRecipient} from "./GenericRecipient.t.sol";
+
+import {InitialState} from "./InitialState.t.sol";
+import {IETHBridge} from "src/protocol/IETHBridge.sol";
+
+contract VaryingFundAmount is DepositRecipientIsMessageRelayer {
+    function setUp() public override {
+        super.setUp();
+    }
+
+    function test_sentZeroAmount_relayMessage_shouldRevert() public zeroAmount {
+        vm.expectRevert(IETHBridge.FailedClaim.selector);
+        _relayMessage();
+    }
+
+    function test_setTipHigherThanAmount_relayMessage_shouldRevert() public amountTooLow {
+        vm.expectRevert(IETHBridge.FailedClaim.selector);
+        _relayMessage();
+    }
+
+    modifier zeroAmount() {
+        ethDeposit.amount = 0;
+        _encodeReceiveCall();
+        _;
+    }
+
+    modifier amountTooLow() {
+        ethDeposit.amount = tip - 1 wei;
+        _encodeReceiveCall();
+        _;
+    }
+}

test/MessageRelayer/GasLimitScenarios.t.sol

@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.28;
+
+import {DepositRecipientIsMessageRelayer} from "./DepositRecipientScenarios.t.sol";
+import {GenericRecipient} from "./GenericRecipient.t.sol";
+
+import {InitialState} from "./InitialState.t.sol";
+import {IETHBridge} from "src/protocol/IETHBridge.sol";
+
+contract UserSetGasLimit is DepositRecipientIsMessageRelayer {
+    function setUp() public override {
+        super.setUp();
+    }
+
+    function test_userSetHighGasLimit_relayMessage_shouldRevert() public gasLimitHigherThanValue {
+        vm.expectRevert(IETHBridge.FailedClaim.selector);
+        _relayMessage();
+    }
+
+    function test_userReasonableGasLimit_relayMessage() public whenGasLimitIsReasonable {
+        _relayMessage();
+    }
+
+    modifier gasLimitHigherThanValue() {
+        gasLimit = amount + 1 wei;
+        _encodeReceiveCall();
+        _;
+    }
+
+    modifier whenGasLimitIsReasonable() {
+        gasLimit = 100_000;
+        _encodeReceiveCall();
+        _;
+    }
+}