fix: 🐛 Fixed void upgrade block-list defaults in limited barrels

Author: P3pp3rF1y

gradle.properties

@@ -15,7 +15,7 @@ loader_version_range=[4,)
 mod_id=sophisticatedcore
 mod_name=Sophisticated Core
 mod_license=All Rights Reserved
-mod_version=1.4.91
+mod_version=1.4.92
 mod_group_id=net.p3pp3rf1y
 mod_authors=P3pp3rF1y
 mod_description=A library / shared functionality mod for Sophisticated Storage and Backpacks

src/main/java/net/p3pp3rf1y/sophisticatedcore/upgrades/FilterLogic.java

@@ -147,6 +147,9 @@ protected void setAttributes(Function<FilterAttributes, FilterAttributes> setter
 
 	public void setAllowByDefault(boolean allowListDefault) {
 		this.allowListDefault = allowListDefault;
+		if (!upgrade.has(filterAttributesComponent)) {
+			emptyAttributes = null;
+		}
 	}
 
 	protected void save() {

src/test/java/net/p3pp3rf1y/sophisticatedcore/upgrades/voiding/VoidUpgradeWrapperTest.java

@@ -63,6 +63,25 @@ void emptyContainedFilterDoesNotMatchFluid() {
 		assertFalse(getVoidUpgradeWrapper().shouldVoidFluid(new FluidStack(Fluids.WATER, 1_000), VoidType.ALWAYS));
 	}
 
+	@Test
+	void setAllowByDefaultUpdatesEmptyFilterAttributes() {
+		VoidUpgradeWrapper wrapper = getVoidUpgradeWrapper();
+
+		wrapper.getFilterLogic().setAllowByDefault(false);
+
+		assertTrue(wrapper.getFilterLogic().matchesFilter(new ItemStack(Items.DIAMOND)));
+	}
+
+	@Test
+	void setAllowByDefaultDoesNotOverridePersistedFilterAttributes() {
+		VoidUpgradeWrapper wrapper = getVoidUpgradeWrapper();
+		wrapper.getFilterLogic().setAllowList(true);
+
+		wrapper.getFilterLogic().setAllowByDefault(false);
+
+		assertFalse(wrapper.getFilterLogic().matchesFilter(new ItemStack(Items.DIAMOND)));
+	}
+
 	private static VoidUpgradeWrapper getVoidUpgradeWrapper() {
 		VoidUpgradeItem upgradeItem = mock(VoidUpgradeItem.class);
 		when(upgradeItem.getFilterSlotCount()).thenReturn(1);