Skip to content

[BugFix] Fix tokenizer_client file name#7590

Open
xiaoxiaohehe001 wants to merge 1 commit intoPaddlePaddle:release/2.6from
xiaoxiaohehe001:fix_tokenizer_client
Open

[BugFix] Fix tokenizer_client file name#7590
xiaoxiaohehe001 wants to merge 1 commit intoPaddlePaddle:release/2.6from
xiaoxiaohehe001:fix_tokenizer_client

Conversation

@xiaoxiaohehe001
Copy link
Copy Markdown
Collaborator

@xiaoxiaohehe001 xiaoxiaohehe001 commented Apr 23, 2026

Motivation

Fix tokenizer_client file name

Modifications

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

Copilot AI review requested due to automatic review settings April 23, 2026 11:08
@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Apr 23, 2026

Thanks for your contribution!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

该 PR 旨在修复 tokenizer_client 模块命名/引用错误:新增(或更正)fastdeploy.input.tokenizer_client 并将原先拼写错误的 tokenzier_client 引用点统一改为正确路径,以恢复相关功能与测试可运行性。

Changes:

  • 将多个文件中的错误导入 fastdeploy.input.tokenzier_client 更正为 fastdeploy.input.tokenizer_client
  • 新增 fastdeploy/input/tokenizer_client.py,提供 AsyncTokenizerClient 及相关请求模型
  • 更新/对齐相应测试用例的导入路径

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/input/test_tokenizer_client.py 修正测试导入路径到 tokenizer_client,确保测试能找到模块
fastdeploy/input/tokenizer_client.py 新增/更正 tokenizer client 实现与请求模型定义
fastdeploy/entrypoints/openai/v1/serving_chat.py 修正 OpenAI serving 侧导入路径
fastdeploy/entrypoints/openai/response_processors.py 修正 response processor 导入路径
fastdeploy/demo/tokenzier_client_demo.py 修正 demo 内导入路径到 tokenizer_client

import asyncio

from fastdeploy.input.tokenzier_client import (
from fastdeploy.input.tokenizer_client import (
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该 demo 文件名仍为 tokenzier_client_demo.py(拼写错误),但内部已改为导入 tokenizer_client。为避免后续用户/脚本按文件名搜索或引用时混淆,建议同时把 demo 文件名也更正为 tokenizer_client_demo.py(并相应更新任何引用/文档链接)。

Copilot uses AI. Check for mistakes.
import respx

from fastdeploy.input.tokenzier_client import (
from fastdeploy.input.tokenizer_client import (
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 描述里的 Modifications / Usage or Command / Accuracy Tests 等章节目前仍为空,同时 Checklist 也未勾选/说明。建议补充:具体改动点(例如重命名/新增 tokenizer_client.py 并更新引用)、如何验证(运行哪些单测/命令),以及如果不需要额外测试的原因,方便 reviewer/CI 追踪。

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown

@PaddlePaddle-bot PaddlePaddle-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Code Review | 2026-04-23 19:15:24

📋 Review 摘要

PR 概述:修复 tokenzier_client(拼写错误,少字母 i)→ tokenizer_client 的模块 import 路径,并重命名对应源文件
变更范围fastdeploy/input/fastdeploy/entrypoints/openai/fastdeploy/demo/tests/input/
影响面 Tag[BugFix] [APIServer] [DataProcessor]


📝 PR 规范检查

① Cherry-Pick 标签缺失:PR 目标分支为 release/2.6(非 develop),按规范标题需在前加 [Cherry-Pick] 并附原 PR 编号。

标题建议(可直接复制):

  • [Cherry-Pick][BugFix] Fix tokenizer_client file name (#XXXX)

请将 #XXXX 替换为该修复在 develop 分支合并时的 PR 编号。

② Modifications 章节未填写:PR 描述中 Modifications 为空,建议补充。

描述建议(可直接复制):

## Modifications
- 将 4 处拼写错误的模块路径 `tokenzier_client`(少字母 `i`)统一修正为 `tokenizer_client`
- 重命名源文件 `fastdeploy/input/tokenzier_client.py` → `tokenizer_client.py`
- 同步修正 `demo/`、`entrypoints/openai/`、`tests/input/` 下的 import 语句

问题

级别 文件 概述
🟡 建议 fastdeploy/demo/tokenzier_client_demo.py:19 文件名本身仍含拼写错误 tokenzier,本次 PR 仅修复了内部 import,未重命名文件

总体评价

改动清晰,属于低风险拼写错误修复,逻辑无误。建议同步重命名 demo 文件本身(tokenzier_client_demo.pytokenizer_client_demo.py),并按规范补充 Cherry-Pick 标签和 Modifications 描述后合入。

import asyncio

from fastdeploy.input.tokenzier_client import (
from fastdeploy.input.tokenizer_client import (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 建议 文件名本身仍含拼写错误

当前文件名为 tokenzier_client_demo.pytokenzier 少了字母 i),本次 PR 仅修复了文件内的 import 路径,但未重命名文件本身。

建议同步将文件重命名为:

tokenizer_client_demo.py

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/2.6@9ef8467). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release/2.6    #7590   +/-   ##
==============================================
  Coverage               ?   73.47%           
==============================================
  Files                  ?      376           
  Lines                  ?    53275           
  Branches               ?     8330           
==============================================
  Hits                   ?    39146           
  Misses                 ?    11370           
  Partials               ?     2759           
Flag Coverage Δ
GPU 73.47% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PaddlePaddle-bot
Copy link
Copy Markdown

🤖 Paddle-CI-Agent | ci_status_monitor | 2026-04-28 17:39:07

CI报告基于以下代码生成(30分钟更新一次):


1 任务总览

1 个 Required 任务失败(Approval),需处理后方可合并。

总执行(rerun次数) 总任务 ✅ 通过 ❌ 失败 ⏳ 运行中 ⏸️ 等待中 跳过
40(0) 40 35 5 0 0 0

2 任务状态汇总

2.1 Required任务 : 9/10 通过

必选任务阻塞合并,失败需优先处理。

状态 任务 耗时 根因 修复建议 日志 重跑
Approval 8s PR问题:缺少 FastDeploy RD 成员审批(1 个审批未满足) 请 RD 成员(qingqing01/Jiang-Jia-Jun/heavengate)审批此 PR Job -
其余 9 个必选任务通过 - - - - -

2.2 可选任务 — 26/30 通过

可选任务不阻塞合并,失败仅供参考。

状态 任务 耗时 日志 重跑
Run iluvatar Tests / run_iluvatar_cases 16m41s Job -
Check PR Template 11s Job -
CI_HPU 2h2m Job -
Trigger Jenkins for PR 40s Job -
其余 26 个可选任务通过 - - -

3 失败详情(仅 required)

Approval — 审批流程(置信度: 高)

Approval

  • 状态: ❌ 失败
  • 错误类型: 审批流程
  • 置信度: 高
  • 根因摘要: PR 合入 release/2.6 缺少 RD 成员审批(1 个审批错误)
  • 分析器: 通用分析(fallback)

根因详情:
本 PR 目标分支为 release/2.6,属于 Cherry-Pick 或 Release 修复类型,CI 脚本 scripts/check_approval.sh 检测到审批要求未满足(exit code 6 = 1个审批错误)。必须由以下 FastDeploy RD 成员之一完成审批:qingqing01(dangqingqing)Jiang-Jia-Jun(jiangjiajun)heavengate(dengkaipeng)

关键日志:

==> PR title: [BugFix] Fix tokenizer_client file name
0. Cherry-Pick PR must come from develop and the title must contain
   [Cherry-Pick] and the original develop PR number (e.g., #5010).
   Approval required from FastDeploy RD: qingqing01(dangqingqing),
   Jiang-Jia-Jun(jiangjiajun), heavengate(dengkaipeng).
There are 1 approved errors.
##[error]Process completed with exit code 6.

修复建议:

  1. 请 FastDeploy RD 成员(qingqing01/Jiang-Jia-Jun/heavengate)在 GitHub 上 Approve 此 PR
  2. 审批完成后,Approval CI 会自动重跑并通过

修复建议摘要: 请 FastDeploy RD 成员 Approve 此 PR

链接: 查看日志

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants