Commit 960305e
test(internal): address Gemini review feedback on host detection and port allocation
- Replace subprocess.run(["docker", "run", ...]) with docker SDK
containers.run() in _detect_docker_host() — avoids shell dependency
- Eliminate TOCTOU port race: bind HTTPServer directly to port 0 and
read srv.server_address[1] instead of pre-allocating with a socket
- Remove now-unused socket import
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 39417ff commit 960305e
1 file changed
Lines changed: 10 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | 25 | | |
27 | 26 | | |
28 | 27 | | |
| |||
205 | 204 | | |
206 | 205 | | |
207 | 206 | | |
208 | | - | |
209 | | - | |
210 | 207 | | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
220 | 215 | | |
221 | | - | |
| 216 | + | |
222 | 217 | | |
223 | 218 | | |
224 | 219 | | |
| |||
242 | 237 | | |
243 | 238 | | |
244 | 239 | | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | 240 | | |
250 | 241 | | |
251 | 242 | | |
252 | 243 | | |
253 | 244 | | |
254 | | - | |
| 245 | + | |
| 246 | + | |
255 | 247 | | |
256 | 248 | | |
257 | 249 | | |
| |||
0 commit comments