Merge pull request #3578 from AritraDey-Dev/fix/biocro-met-download

fix(biocro): handle met data end time in met2model.BIOCRO to prevent run end date error

Author: infotroph

models/biocro/tests/testthat/test.met2model.R

@@ -5,10 +5,6 @@ setup(dir.create(outfolder, showWarnings = FALSE))
 teardown(unlink(outfolder, recursive = TRUE))
 
 test_that("Met conversion runs without error", {
-  skip(paste0(
-    "BIOCRO met2model is currently broken. ",
-    "See issue #2274 (https://github.com/PecanProject/pecan/issues/2274)."
-  ))
   nc_path <- system.file("test-data", "CRUNCEP.2000.nc",
                          package = "PEcAn.utils")
   in.path <- dirname(nc_path)

modules/data.atmosphere/R/load.cfmet.R

@@ -51,11 +51,19 @@ load.cfmet <- function(met.nc, lat, lon, start.date, end.date) {
 
   all.dates <- data.frame(index = seq_along(time.idx), date = date)
 
-  if (start.date + lubridate::days(1) < min(all.dates$date)) {
-   PEcAn.logger::logger.severe("run start date", start.date, "before met data starts", min(all.dates$date))
+  delta <- stats::median(diff(all.dates$date), na.rm = TRUE)
+  if (is.na(delta)) {
+    # probably only happens with a one-line met file
+    # fall back to requiring exact match
+    delta <- 0
   }
-  if (end.date > max(all.dates$date)) {
-   PEcAn.logger::logger.severe("run end date", end.date, "after met data ends", max(all.dates$date))
+  
+  if (start.date < (min(all.dates$date) - delta)) {
+    PEcAn.logger::logger.severe("run start date", start.date, "before met data starts", min(all.dates$date))
+  }
+  
+  if (end.date > (max(all.dates$date) + delta)) {
+    PEcAn.logger::logger.severe("run end date", end.date, "after met data ends", max(all.dates$date))
   }
 
   run.dates <- all.dates %>%

modules/data.atmosphere/tests/testthat/test.load.cfmet.R

@@ -49,7 +49,7 @@ test_that("load.cfmet throws error if start/end date out of range",{
                           start.date = "1950-12-31", end.date = "1951-12-31"),
                "run start date .* before met data starts")
   expect_error(load.cfmet(met.nc = daily.nc, lat = 39, lon = -88,
-                          start.date = "1951-01-02", end.date = "1952-01-01"),
+                          start.date = "1951-01-02", end.date = "1952-01-15"),
                "run end date .* after met data ends")
 })