Merge pull request #3640 from AritraDey-Dev/fix/sipnet-download-check

Handle null status in SIPNET download script For DEMO 1 Notebook

Author: dlebauer

documentation/tutorials/Demo_1_Basic_Run/download_sipnet.R

@@ -39,19 +39,31 @@ download.file(
 Sys.chmod(dest_path, mode = "0755")
 
 ## Now we are run, lets just check that `sipnet -h` works
-
-status <- suppressWarnings(
-    system2(dest_path, "-h", stderr = TRUE, stdout = TRUE) |>
-        attr("status")
+tryCatch(
+  {
+    # This block runs if system2 succeeds with exit code 0 (status attribute is NULL).
+    # This is unexpected for `sipnet -h`, so we warn but assume it's OK.
+    system2(dest_path, "-h", stderr = TRUE, stdout = TRUE)
+    PEcAn.logger::logger.warn("SIPNET ran with exit code 0, but expected 1. Assuming installation is OK.")
+  },
+  warning = function(w) {
+    # This block runs if system2 returns a non-zero exit code, which is expected.
+    # We check the warning message for the expected status of 1.
+    if (grepl("had status 1", w$message, fixed = TRUE)) {
+      PEcAn.logger::logger.info("SIPNET has been installed!")
+    } else {
+      PEcAn.logger::logger.error("SIPNET ran but failed with an unexpected status.", "Details:", w$message)
+    }
+  },
+  error = function(e) {
+    # This block runs if system2 fails to execute the command at all.
+    PEcAn.logger::logger.error(
+      "SIPNET command failed to execute. The binary may be incompatible with your system.",
+      "Details:", e$message
+    )
+  }
 )
 
-if(status == 1){
-    # 1 is expected for `sipnet -h`
-    PEcAn.logger::logger.info("SIPNET has been installed!")
-} else {
-    PEcAn.logger::logger.error("SIPNET installation has failed with status:", status)
-}
-
 dir.create("dbfiles", showWarnings = FALSE)
 # Download demo .clim file
 climfile <- "https://gist.githubusercontent.com/dlebauer/8aea1146dc8f915e1dea7a7335d7ec24/raw/4cc127098b0b42a0d428fc7de580e17aafca4e8b/AMF_US-NR1_BASE_HH_23-5.2004-01-01.2004-12-31.clim"