Improve the tag regex maintenance

[wuhuizuo]

          > **I have already done a preliminary review for you, and I hope to help you do a better job.**

Summary:
The pull request updates the pingcap-get-set-release-version-v2.yaml task configuration file to add support for the CSE version format and delete date style tags. The changes involve updating the regular expressions used for tag filtering and adding a step to delete date tags. Overall, the changes seem to enhance the functionality of the task.

Critical Issues:

• Potential Bug - Tag Deletion Logic: In the updated script, there is a risk that the git tag -d command might delete tags that should not be deleted due to the regular expression used for filtering. This could result in unintentional deletion of important tags.
  • File: apps/prod/tekton/configs/tasks/pingcap-get-set-release-version-v2.yaml
  • Lines: 19-24
  • Issue: The regular expression used to filter tags for deletion may not accurately target only the date style tags.
  • Suggested Solution: Review and update the regular expression to ensure it correctly identifies only the date style tags for deletion.

Code Improvements:

• Code Readability - Extract Magic Values: The regular expressions used in the script are hard-coded and might benefit from being extracted into named variables for better readability and maintainability.
  • File: apps/prod/tekton/configs/tasks/pingcap-get-set-release-version-v2.yaml
  • Lines: 9-10, 12
  • Issue: Hard-coded regular expressions can make the script harder to understand and modify in the future.
  • Suggested Solution: Define named variables for the regular expressions to improve readability and ease of maintenance.

    # Define named variables for regular expressions
    standard_tag_regex: "v[0-9]+[.][0-9]+[.][0-9]+(-(alpha|beta|fips|cse)([.][0-9]+)?)?$"
    date_tag_regex: "^v20[0-9][0-9].[0-1]{1,2}.[0-3][0-9]"

Best Practices:

• Documentation - Add Comments: The script lacks comments to explain the purpose of certain sections or steps. Adding comments can improve code maintainability and help other developers understand the logic.
  • File: apps/prod/tekton/configs/tasks/pingcap-get-set-release-version-v2.yaml
  • Lines: Add comments as necessary to describe the functionality of different sections of the script.
• Testing Coverage - Include Tests: If not already in place, consider adding tests for the updated functionality to ensure that the changes work as intended and do not introduce regressions.
• Naming Conventions - Use Descriptive Names: Ensure that variable names and comments are descriptive and follow naming conventions to enhance code readability and maintainability.

Originally posted by @ti-chi-bot[bot] in #1494 (comment)