Commit e4cf777
docs(agents): the querybuilder skill named a parameter type that never existed
`pormg-querybuilder-internals` called the bucketed collector
`PormGPositionalParam` in its *Parameter routing* section and again in the
maintenance checklist. That identifier appears nowhere in `src/` — the abstract
type is `PormGSQLiteParam`, with `SQLiteParameterizedQuery` as its concrete
subtype. Anyone reading the skill to understand #432 was handed a name they could
not grep, in the exact section #432 rewrites. `test_alignment_sqlite.jl` carried
the same ghost name in a comment.
The checklist's "update `get_final_parameters` flatten order" entry now points at
`_BUCKET_ORDER`, which is the single list both `get_final_parameters` and
`detach_nested_run!` read — #432 made that genuinely single-sourced rather than
two hand-written copies that must agree.
Adds the rule the four nested-render sites now follow, so the next person editing
this area does not have to rediscover it: a nested render does not pick a bucket.
Its values are marked, lifted and re-emitted as one clause-ordered run at the
parent's marker position, because binding order is not text order — a build binds
joins last and renders them first, which is the difference the buckets exist to
reconcile.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 6f247c3 commit e4cf777
1 file changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
47 | 49 | | |
48 | | - | |
| 50 | + | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| |||
54 | 56 | | |
55 | 57 | | |
56 | 58 | | |
57 | | - | |
| 59 | + | |
58 | 60 | | |
59 | 61 | | |
60 | 62 | | |
| |||
235 | 237 | | |
236 | 238 | | |
237 | 239 | | |
238 | | - | |
| 240 | + | |
| 241 | + | |
239 | 242 | | |
240 | 243 | | |
241 | 244 | | |
| |||
0 commit comments